From owner-freebsd-stable@FreeBSD.ORG Wed Jul 12 14:27:06 2006 Return-Path: X-Original-To: freebsd-stable@FreeBSD.org Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD66D16A4E1; Wed, 12 Jul 2006 14:27:06 +0000 (UTC) (envelope-from jhein@timing.com) Received: from Daffy.timing.com (w.timing.com [206.168.13.218]) by mx1.FreeBSD.org (Postfix) with ESMTP id C4BFA43D45; Wed, 12 Jul 2006 14:27:05 +0000 (GMT) (envelope-from jhein@timing.com) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id k6CER5MP071527; Wed, 12 Jul 2006 08:27:05 -0600 (MDT) (envelope-from jhein@timing.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.13.6/8.13.6) with ESMTP id k6CER3rj021828; Wed, 12 Jul 2006 08:27:03 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.13.6/8.13.6/Submit) id k6CER3Dq021825; Wed, 12 Jul 2006 08:27:03 -0600 (MDT) (envelope-from jhein) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17589.1719.666455.768409@gromit.timing.com> Date: Wed, 12 Jul 2006 08:27:03 -0600 From: John E Hein To: Sergey Matveychuk In-Reply-To: <44B4CDE3.60205@FreeBSD.org> References: <44B40863.9060403@asd.aplus.net> <44B483B8.6000005@FreeBSD.org> <44B4A164.50003@asd.aplus.net> <44B4CDE3.60205@FreeBSD.org> X-Mailer: VM 7.19 under Emacs 21.3.1 X-Virus-Scanned: ClamAV version 0.87.1, clamav-milter version 0.87 on Daffy.timing.com X-Virus-Status: Clean Cc: freebsd-stable@FreeBSD.org Subject: Re: portupgrade bug: -M no longer works after v2.1.0 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2006 14:27:06 -0000 Sergey Matveychuk wrote at 14:24 +0400 on Jul 12, 2006: > Both -m and -M works fine but do different things. -m pass its argument > as make file argument(s) and -M pass its argument as environment > variable(s). You can't set make variable with environment variable. They > are different! > > -M has never worked as you expected. You can test it with a command: > %cd /usr/ports/www/apache13 > %env APACHE_HARD_SERVER_LIMIT=1024 make > against of > % make APACHE_HARD_SERVER_LIMIT=1024 > > I think you confuse the two variables types. This is incorrect. make(1) looks at the environment for variables. See the man page. If you tested your example, you'd see that it works fine. make APACHE_HARD_SERVER_LIMIT=22 -V CFLAGS -O2 -fno-strict-aliasing -pipe -DDOCUMENT_LOCATION=\\\\\"/usr/local/www/data\\\\\" -DDEFAULT_PATH=\\\\\"/bin:/usr/bin:/usr/local/bin\\\\\" -DHARD_SERVER_LIMIT=22 env APACHE_HARD_SERVER_LIMIT=22 make -V CFLAGS -O2 -fno-strict-aliasing -pipe -DDOCUMENT_LOCATION=\\\\\"/usr/local/www/data\\\\\" -DDEFAULT_PATH=\\\\\"/bin:/usr/bin:/usr/local/bin\\\\\" -DHARD_SERVER_LIMIT=22