From owner-freebsd-virtualization@FreeBSD.ORG Thu Aug 28 21:40:13 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0CB06106567C for ; Thu, 28 Aug 2008 21:40:13 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id B54378FC18 for ; Thu, 28 Aug 2008 21:40:12 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id B260141C891 for ; Thu, 28 Aug 2008 23:40:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id DFSrM+VfENsV for ; Thu, 28 Aug 2008 23:40:10 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 4C0AC41C88A; Thu, 28 Aug 2008 23:40:10 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id E2AEB44487F for ; Thu, 28 Aug 2008 19:03:30 +0000 (UTC) Date: Thu, 28 Aug 2008 19:03:30 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: FreeBSD virtualization mailing list Message-ID: <20080828185639.P66593@maildrop.int.zabbadoz.net> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Subject: Step 1.5 needs review X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2008 21:40:13 -0000 Hi, in case you are interested or have volunteered before to review Step 1.5 as described on http://wiki.freebsd.org/Image/Notes200808DevSummit there are few things to do: - review the diff (Julian posted an initial one). - make sure all (relevant) sysctl were caught. - make sure the INIT_VNET_* macro is there whereever it is needed. - do builds according to "HOWTO verify that the pure style changes are all right" on the above mentioned page and verify that it is all style changes. In case there are others we shoudl decide to either commit them either upfront or afterwards if possible. - the 'include headers' one way or the other (as we have discussed at the devsummit and that Julian has told me again) needs resolving. As this has bikeshed potential, I'd prefer that the 'singed up' reviewers decide that. - possibly more... The plan would be to have a final patch by Monday morning UTC to be comitted by a volunteer. Regards, Bjoern -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.