From owner-freebsd-current@FreeBSD.ORG Sat Aug 18 06:49:32 2012 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F23681065670 for ; Sat, 18 Aug 2012 06:49:31 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7B23C8FC08 for ; Sat, 18 Aug 2012 06:49:31 +0000 (UTC) Received: by weyx56 with SMTP id x56so3577361wey.13 for ; Fri, 17 Aug 2012 23:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=qvbjDUjSQSIdtZgIlZL5KYd4sS6zry6FctvUjFxEnac=; b=Gy0odkTUySGl3ap35o/v2/i09bgVk6fCU8gCwxfEn/CHcoOeghTylU3EP7KfSx8Xla b52tfjb5OvJPw1OQDIZ23goRtP9auQi7cRSWz499aIGOr9uy8RrqsLriJBFC58v6p2yV tkrl0IRLf3vwp0qRBx1tJCeaq2PG9YVC6hby1oj1oZolMTMysQnQkTqt4zTcyIUKnwY1 p5w9SJDM6AgMANj1Yehtleo5p6wF6lHmjarJ8py9iwZGYo4m0mImyUpnPILed1Sw/nBd rXWZpZEuVwxiUVpqrOdc85ejOv3YxGrhFcYbs1YIdc6xz4bbyUynOh5lTg7KpcMriMOz h7Og== MIME-Version: 1.0 Received: by 10.216.138.73 with SMTP id z51mr3814037wei.39.1345272570239; Fri, 17 Aug 2012 23:49:30 -0700 (PDT) Received: by 10.223.63.76 with HTTP; Fri, 17 Aug 2012 23:49:30 -0700 (PDT) In-Reply-To: <1345242190.27688.162.camel@revolution.hippie.lan> References: <157941699.20120815004542@serebryakov.spb.ru> <502AE8B5.9090106@FreeBSD.org> <502B775D.7000101@FreeBSD.org> <1849591745.20120815144006@serebryakov.spb.ru> <1345139226.27688.48.camel@revolution.hippie.lan> <174138639.20120817143840@serebryakov.spb.ru> <1345215393.27688.85.camel@revolution.hippie.lan> <1345223506.27688.116.camel@revolution.hippie.lan> <1345242190.27688.162.camel@revolution.hippie.lan> Date: Fri, 17 Aug 2012 23:49:30 -0700 Message-ID: From: Kevin Oberman To: Ian Lepore Content-Type: text/plain; charset=UTF-8 Cc: current@freebsd.org Subject: Re: CURRENT as gateway on not-so-fast hardware: where is a bottlneck? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Aug 2012 06:49:32 -0000 On Fri, Aug 17, 2012 at 3:23 PM, Ian Lepore wrote: > On Fri, 2012-08-17 at 14:29 -0700, Kevin Oberman wrote: >> On Fri, Aug 17, 2012 at 10:11 AM, Ian Lepore >> > No! Not bde! He'll notice that I violated style(9) by accidentally >> > leaving an extra blank line between a comment block and the function >> > definition. :) (There are probably more violations than that -- I did >> > this when I was first trying to come to grips with the differences >> > between style(9) and the almost-style(9) standards we use at work.) >> > >> > When I first proposed the changes, jhb remarked that they sounded good, >> > but as far as I know, nobody reviewed the actual diff when I posted it. >> > It looks like bde and phk were the primary maintainers back when this >> > code was being more actively worked on. >> >> Why not bde? Everyone needs to learn what the term "bruceification" means. >> >> Believe me, there IS good reason for programming style and almost >> everyone with a commit bit gets close. bde will provide a reminder of >> any of those things you forgot were in style(9). This is something we >> should appreciate, even if it does sting a bit. > > Did you miss the smiley I buried between two sentences there? > > Having worked on code written with no style guidelines, I totally > understand the need for consistent style. While I find a couple of > style(9)'s edicts to be massively annoying, all in all I'd rather work > on code that has a consistent style I hate than on code with no > consistency. Nope. I didn't miss it, but you missed the one I neglected to type at the end of the first line in my message. I really appreciate all that he does including being the foremost style(9) checker. Besides, many of the newer folks around here may not understand just what "bruceification" is. Only those whose code has not caught his attention, though. :-) (I remembered, this time) -- R. Kevin Oberman, Network Engineer E-mail: kob6558@gmail.com