From owner-cvs-all Tue Dec 17 9:33:39 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7457237B404 for ; Tue, 17 Dec 2002 09:33:38 -0800 (PST) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B97243ED1 for ; Tue, 17 Dec 2002 09:33:36 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 5846 invoked from network); 17 Dec 2002 17:33:40 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 17 Dec 2002 17:33:40 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id gBHHXYUT012511; Tue, 17 Dec 2002 12:33:34 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20021215142734.A37709@unixdaemons.com> Date: Tue, 17 Dec 2002 12:33:34 -0500 (EST) From: John Baldwin To: Bosko Milekic Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, Maxim Konovalov , Robert Watson , Matthew Dillon , Hiten Pandya Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 15-Dec-2002 Bosko Milekic wrote: > > > On Sun, Dec 15, 2002 at 02:13:49PM -0500, Hiten Pandya wrote: >> On Sun, Dec 15, 2002 at 10:06:33AM -0800, Matthew Dillon wrote the words in effect of: >> > We had similar problems with the B_ flags. I recommend changing all the >> > mbuf flags from M_ to MB_, and perhaps rename the MB_ defines in >> > sys/mchain.h to MC_ or MBC_. >> > >> > -Matt >> >> That was on the tip of my tongue! :) This also makes it easier to >> distinguish between the flags easily, and stops confusion. I am prepared >> to do the dirty work, if given the go ahead... but not anytime before >> christmas. :) > > You people realize that you're going to have 123019301293 people > yelling at you for breaking 'compatibility' with the other BSDs? I > won't be one of those 123019301293 people, but rest assured that they > do lurk around these parts. You can add compat macros for other BSD's or some such. Using overly simple namespaces is just asking for confusion. We've already seen other instances due to the ambiguity of MSIZE. m_* can mean meany things, but mb_* or mbuf_* means a lot fewer. When BSD/OS first gave us their mutex code all the MTX_* macros were M_*, but we changed it to MTX_* to avoid exactly this type of situation and BSD/OS changed their macro names as well. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message