From owner-svn-src-all@freebsd.org Mon Jun 17 15:51:20 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A05F15BDD7C; Mon, 17 Jun 2019 15:51:20 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA4316F811; Mon, 17 Jun 2019 15:51:19 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x5HFpGpN009680; Mon, 17 Jun 2019 08:51:16 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x5HFpGbI009679; Mon, 17 Jun 2019 08:51:16 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201906171551.x5HFpGbI009679@gndrsh.dnsmgr.net> Subject: Re: svn commit: r349133 - head/share/man/man4 In-Reply-To: To: Niclas Zeising Date: Mon, 17 Jun 2019 08:51:16 -0700 (PDT) CC: rgrimes@freebsd.org, Benjamin Kaduk , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: CA4316F811 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.969,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jun 2019 15:51:20 -0000 > On 2019-06-17 12:27, Niclas Zeising wrote: > > On 2019-06-17 11:03, Rodney W. Grimes wrote: > >>> On 2019-06-17 09:56, Benjamin Kaduk wrote: > >>>> On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising >>>> > wrote: > >>>> > >>>> ???? Author: zeising (doc,ports committer) > >>>> ???? Date: Mon Jun 17 05:41:47 2019 > >>>> ???? New Revision: 349133 > >>>> ???? URL: https://svnweb.freebsd.org/changeset/base/349133 > >>>> > >>>> ???? Log: > >>>> ????? ? pci(4): Document PCIOCATTACHED > >>>> > >>>> ????? ? Document the PCIOCATTACHED ioctl(2) in the pci(4) manual. > >>>> ????? ? PCIOCATTACHED is used to query if a driver has attached to a > >>>> PCI. > >>>> > >>>> ????? ? Reviewed by:? bcr, imp > >>>> ????? ? MFC after:? ? 2 weeks > >>>> ????? ? Differential Revision: https://reviews.freebsd.org/D20652 > >>>> > >>>> ???? Modified: > >>>> ????? ? head/share/man/man4/pci.4 > >>>> > >>>> ???? Modified: head/share/man/man4/pci.4 > >>>> > >>>> ============================================================================== > >>>> > >>>> ???? --- head/share/man/man4/pci.4? ?Mon Jun 17 03:48:44 2019 > >>>> ???? (r349132) > >>>> ???? +++ head/share/man/man4/pci.4? ?Mon Jun 17 05:41:47 2019 > >>>> ???? (r349133) > >>>> ???? @@ -24,7 +24,7 @@ > >>>> ????? ?.\" > >>>> ????? ?.\" $FreeBSD$ > >>>> ????? ?.\" > >>>> ???? -.Dd June 14, 2018 > >>>> ???? +.Dd June 17, 2019 > >>>> ????? ?.Dt PCI 4 > >>>> ????? ?.Os > >>>> ????? ?.Sh NAME > >>>> ???? @@ -333,6 +333,26 @@ The limitations on data width described for > >>>> ????? ?reading registers, above, also apply to writing > >>>> ????? ?.Tn PCI > >>>> ????? ?configuration registers. > >>>> ???? +.It PCIOCATTACHED > >>>> ???? +This > >>>> ???? +.Xr ioctl 2 > >>>> ???? +allows users to query if a driver is attached to the > >>>> ???? +.Tn PCI > >>>> ???? +specified in the passed-in > >>>> > >>>> > >>>> Is there a missing word like "device" here? > >> > >> Actally I think the missing word, in both cases, is register, > >> unless I am misreading some part of the manual page and > >> what a struct pci_io points at.? I guess if the pi_reg is null > >> then this would be device.? Either way there is defanity a > >> missing word. > > > > I'll try to fix this.? In the PCIOCWRITE case, perhaps register is best, > > however, inthe PCIOCATTACHED case, device is best, I think. > > I'll create a patch and put it for review, I'll get back to you once > > it's done. > > Regards > > > > Here's the review with my proposed change. Let me know what you think. > https://reviews.freebsd.org/D20671 This looks good to me, cant login right now to hit accept, but consider the rewview accepted by me too. -- Rod Grimes rgrimes@freebsd.org