From owner-cvs-src@FreeBSD.ORG Fri Jun 30 11:44:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C5D216A503; Fri, 30 Jun 2006 11:44:16 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74FF444660; Fri, 30 Jun 2006 11:44:15 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k5UBiBqh021153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 30 Jun 2006 15:44:12 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k5UBiBI7021149; Fri, 30 Jun 2006 15:44:11 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 30 Jun 2006 15:44:10 +0400 From: Gleb Smirnoff To: Yar Tikhiy Message-ID: <20060630114410.GZ1383@FreeBSD.org> References: <200606291922.k5TJM5ev007314@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200606291922.k5TJM5ev007314@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c if_atmsubr.c if_stf.c if_tun.c src/sys/netinet if_ether.c ip_divert.c ip_fw2.c src/sys/netinet6 in6.c in6_var.h src/sys/nfsclient bootp_subr.c nfs_diskless.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2006 11:44:16 -0000 On Thu, Jun 29, 2006 at 07:22:05PM +0000, Yar Tikhiy wrote: Y> Modified files: Y> sys/net if.c if_atmsubr.c if_stf.c if_tun.c Y> sys/netinet if_ether.c ip_divert.c ip_fw2.c Y> sys/netinet6 in6.c in6_var.h Y> sys/nfsclient bootp_subr.c nfs_diskless.c Y> Log: Y> There is a consensus that ifaddr.ifa_addr should never be NULL, Y> except in places dealing with ifaddr creation or destruction; and Y> in such special places incomplete ifaddrs should never be linked Y> to system-wide data structures. Therefore we can eliminate all the Y> superfluous checks for "ifa->ifa_addr != NULL" and get ready Y> to the system crashing honestly instead of masking possible bugs. Y> Y> Suggested by: glebius, jhb, ru I think this can also close few reports from Coverity. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE