From nobody Tue Apr 5 19:55:56 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4EC711A92EEA; Tue, 5 Apr 2022 19:55:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KXz0Y1Fn7z4Xkp; Tue, 5 Apr 2022 19:55:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649188557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LL4fNPlinBx5wDUyLnUMlUgHDDGJYnLex9uWMKHnav4=; b=YCpc4ao+ad0G1YXTmAnEM0iCrLzsQDY4OuZPda+E5rSw+lLoDR1GhVegdhoaN70LEDrzw5 k227QfwQhvAxKDedu9zFQxjqu+2o+6HTOfkmfqlankCJD+9wzwtln0AoEI/kNUkkWPEi1E b+ryD/QOc+71weyr+G5H6GdzGxfG+ZuUaY1HN039dw0fJQ+MHXDiv6CF8XtsuBDliB3imm 6L7jzWWSlh5rW6+uOOHMN7ddwAI0+U6vSI9F6dTWYLrmg7UIElMsgPOP+Wy3gF7ZiTNBQd OZNU/vEsywu0oMI3CY+ruIfivXXmO4FF8B7d3ruVG76V1xSVDs1Cu0Ie+HDk1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EE5FE4FB2; Tue, 5 Apr 2022 19:55:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 235Jtu9E052407; Tue, 5 Apr 2022 19:55:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 235Jtuqx052406; Tue, 5 Apr 2022 19:55:56 GMT (envelope-from git) Date: Tue, 5 Apr 2022 19:55:56 GMT Message-Id: <202204051955.235Jtuqx052406@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 6e5056a903cc - main - bwi: Remove write-only variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6e5056a903ccad5c5e9da543f77f9e0fe55489fb Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649188557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LL4fNPlinBx5wDUyLnUMlUgHDDGJYnLex9uWMKHnav4=; b=Ka2IOSWyOnahW7D01XE6bXvaSFzDQZXt9O3YJ2hE8xxWIPmxGy6iT1hmnJwjvyUUpxCK8O gdAr/VGuxum9/hfcH+UwM+9Sxeiq7PAUECS3Lye0OY69ySlt2Tgy0hoh+owxIfFndrUS2Z qZwvvMy5UWfP04egRq+AM4OuAz+QAD31JDYOOzuN0p/o1u0jD1lTcE1lQ0PraHfkJPIapB IQYnKingKwpblTEP3GAiSNJxgQ12IiudekS5lf/DYgkTsEpyNMBEQmVzBa3rbipzl+z8rO 3YZv3DcG+qR8OtytS45f9TBI2oF8lI11H6pd0QplWfhWf8gL16iqJZr81ev14A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649188557; a=rsa-sha256; cv=none; b=CJ39kyK5//l/qohNjhh09DxmiTnbWzt7KyOsHeU2v16leU8SqbCmSUGFzwXztdVI4zUPGU lIDhjn4/3mIEo7IyhDohCAd/XDQRSA9eZkB1Gh7JE8zrwHl2ExSuRi1H/pyYTT3eBwLynL bEzzZ/ug6CygAd5Cp4LIQ5AzlffScPmzrEyAGMkyoa8KJ06mkWDEbNuSEr73GIGoV0Ey2/ paHm14N8xekSRjgBgb2wkQdrroGTTrzPGACrMHdNHuvpttwuB+n0tlTM2oCMgiUwLA5hKN gUI2S+U10wPKYQvB52RgM3lEV/aRL12lXdSg1i7Bru2TGFLQGSj8vmfCYfh1ag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=6e5056a903ccad5c5e9da543f77f9e0fe55489fb commit 6e5056a903ccad5c5e9da543f77f9e0fe55489fb Author: Warner Losh AuthorDate: 2022-04-05 19:07:20 +0000 Commit: Warner Losh CommitDate: 2022-04-05 19:52:54 +0000 bwi: Remove write-only variable bbp_atten is write-only: we don't use it later in bwi_rf_calc_nrssi_slope_11b. However, we may also be able to eliminate the read of this value from the device. However, The documationation for this hardware is thing and I can't test this card so I've left the read of this register in case it's required. Sponsored by: Netflix --- sys/dev/bwi/bwirf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/bwi/bwirf.c b/sys/dev/bwi/bwirf.c index 1345c64d126a..e3a3d1b88e5f 100644 --- a/sys/dev/bwi/bwirf.c +++ b/sys/dev/bwi/bwirf.c @@ -1649,7 +1649,7 @@ bwi_rf_calc_nrssi_slope_11b(struct bwi_mac *mac) struct bwi_phy *phy = &mac->mac_phy; uint16_t save_rf[SAVE_RF_MAX]; uint16_t save_phy[SAVE_PHY_MAX]; - uint16_t ant_div, bbp_atten, chan_ex; + uint16_t ant_div, chan_ex; int16_t nrssi[2]; int i; @@ -1662,7 +1662,7 @@ bwi_rf_calc_nrssi_slope_11b(struct bwi_mac *mac) save_phy[i] = PHY_READ(mac, save_phy_regs[i]); ant_div = CSR_READ_2(sc, BWI_RF_ANTDIV); - bbp_atten = CSR_READ_2(sc, BWI_BBP_ATTEN); + CSR_READ_2(sc, BWI_BBP_ATTEN); chan_ex = CSR_READ_2(sc, BWI_RF_CHAN_EX); /*