From owner-svn-src-all@FreeBSD.ORG Mon Oct 29 04:41:12 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 10B6F75B; Mon, 29 Oct 2012 04:41:12 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-da0-f54.google.com (mail-da0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id B29988FC08; Mon, 29 Oct 2012 04:41:11 +0000 (UTC) Received: by mail-da0-f54.google.com with SMTP id z9so2294046dad.13 for ; Sun, 28 Oct 2012 21:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=wU5qdmCDtC4hXDYcqXksFwZupBDAv31xt5DpvnEYcSY=; b=wqDJqRI6YQca2V6IAWFpj4mh7wn12ydpxHy08cLHwtWyQmoDvSW9ZoNwJ3gOWb/B1V mt6u//nxr3cQy0X/hHwzCULobkRSrDsIIvSfWpRtIJomixdpCEPot/6Mpwaz7SazeL0a q/1vZIKcGrytY2k7KSpHoqHO5MTAS0J7zscpi4x7RhOHqX+d1q0RGMBHGvRfcI5DinVu DkzYsA1kKUr1x/GQB7jt0yJ4DzdXYAt63Z9ENWueOaBOYgYOn4vIkoCH4OC+ZiEfMYcQ 9Jf2tU9PBxqht4fovUR7oIkNpdoVUpOcCKU54MHgIejjU8eN6A/RhvlhYqDajX1WX/o8 0fgw== Received: by 10.68.239.198 with SMTP id vu6mr90403684pbc.109.1351485671110; Sun, 28 Oct 2012 21:41:11 -0700 (PDT) Received: from pyunyh@gmail.com (lpe4.p59-icn.cdngp.net. [114.111.62.249]) by mx.google.com with ESMTPS id nu8sm5332364pbc.45.2012.10.28.21.41.07 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 28 Oct 2012 21:41:10 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Mon, 29 Oct 2012 13:41:04 -0700 From: YongHyeon PYUN Date: Mon, 29 Oct 2012 13:41:04 -0700 To: Gleb Smirnoff Subject: Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf Message-ID: <20121029204104.GA1431@michelle.cdnetworks.com> References: <201210262106.q9QL6YgY000943@svn.freebsd.org> <508BBE6C.7010409@freebsd.org> <20121027220137.GJ70741@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121027220137.GJ70741@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andre Oppermann X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: pyunyh@gmail.com List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2012 04:41:12 -0000 On Sun, Oct 28, 2012 at 02:01:37AM +0400, Gleb Smirnoff wrote: > On Sat, Oct 27, 2012 at 12:58:52PM +0200, Andre Oppermann wrote: > A> On 26.10.2012 23:06, Gleb Smirnoff wrote: > A> > Author: glebius > A> > Date: Fri Oct 26 21:06:33 2012 > A> > New Revision: 242161 > A> > URL: http://svn.freebsd.org/changeset/base/242161 > A> > > A> > Log: > A> > o Remove last argument to ip_fragment(), and obtain all needed information > A> > on checksums directly from mbuf flags. This simplifies code. > A> > o Clear CSUM_IP from the mbuf in ip_fragment() if we did checksums in I'm not sure whether ti(4)'s checksum offloading for IP fragmented packets(CSUM_IP_FRAGS) still works after this change. ti(4) requires CSUM_IP should be set for IP fragmented packets. Not sure whether it's a bug or not. I have a ti(4) controller but I don't remember where I can find it and don't have a link parter(1000baseSX) to test it. :-( > A> > hardware. Some driver may not announce CSUM_IP in theur if_hwassist, > A> > although try to do checksums if CSUM_IP set on mbuf. Example is em(4). em(4) had TX IP checksum offloading support but it was removed without justification. There could be some reason on that decision but I don't see any compelling reason. > A> > A> I'm not getting your description here? Why work around a bug in a driver > A> in ip_fragment() when we can fix the bug in the driver? > > Well, that was actually bug in the stack and a very special driver that > demonstrates it. I may even agree that driver is incorrect, but the stack was > incorrect, too. > > -- > Totus tuus, Glebius.