From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Dec 5 02:50:02 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8329816A41B for ; Wed, 5 Dec 2007 02:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6F3A313C4CC for ; Wed, 5 Dec 2007 02:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lB52o28K019437 for ; Wed, 5 Dec 2007 02:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lB52o2TT019436; Wed, 5 Dec 2007 02:50:02 GMT (envelope-from gnats) Date: Wed, 5 Dec 2007 02:50:02 GMT Message-Id: <200712050250.lB52o2TT019436@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Eric van Gyzen Cc: Subject: Re: ports/118358: math/R update from 2.6.0 to 2.6.1 version X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eric van Gyzen List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2007 02:50:02 -0000 The following reply was made to PR ports/118358; it has been noted by GNATS. From: Eric van Gyzen To: bug-followup@FreeBSD.org, Vittorio De Martino Cc: Subject: Re: ports/118358: math/R update from 2.6.0 to 2.6.1 version Date: Tue, 04 Dec 2007 20:20:32 -0600 Vittorio, Thanks for your patch. It looks good, but I have some suggestions. The patch removes several %%FOO%% prefixes from the pkg-plist, such as: -%%TCLTK%%lib/R/library/tcltk/libs/tcltk.so +lib/R/library/tcltk/libs/tcltk.so The %%FOO%% prefixes exist to support the Makefile's OPTIONS; they should not be removed. See: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html There are a few @dirrm lines that should not change %%DOCSDIR%% to share/doc. The man pages need not be specified in the pkg-plist; the MAN1 variable in the Makefile handles them. Thanks for your work! I'll gladly review a revised patch. Eric