From owner-cvs-all Thu Apr 23 04:06:07 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id EAA16998 for cvs-all-outgoing; Thu, 23 Apr 1998 04:06:07 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA16993 for ; Thu, 23 Apr 1998 04:06:04 -0700 (PDT) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id LAA24333; Thu, 23 Apr 1998 11:05:51 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id NAA02727; Thu, 23 Apr 1998 13:05:50 +0200 (MET DST) Message-ID: <19980423130550.30970@follo.net> Date: Thu, 23 Apr 1998 13:05:50 +0200 From: Eivind Eklund To: Bruce Evans , cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys time.h References: <199804230336.NAA30536@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <199804230336.NAA30536@godzilla.zeta.org.au>; from Bruce Evans on Thu, Apr 23, 1998 at 01:36:19PM +1000 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Thu, Apr 23, 1998 at 01:36:19PM +1000, Bruce Evans wrote: > >eivind 1998/04/22 17:11:32 PDT > > > > Modified files: > > sys/sys time.h > > Log: > > Wrap timerclear in do { ... } while(0) > > Wrong fix. The do-while(0) hack is bogus for macros that expand to an > expression. I strongly disagree. Such macros should most definately have do { ... } while(0) protection, to avoid people depending on the fact that they just happen to be expressions. Otherwise, we're inviting people to depend on implementation details. Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message