From owner-freebsd-stable@FreeBSD.ORG  Mon Feb 23 11:54:14 2009
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2993F1065672
	for <freebsd-stable@freebsd.org>; Mon, 23 Feb 2009 11:54:14 +0000 (UTC)
	(envelope-from prvs=0305a14c0b=ob@gruft.de)
Received: from obh.snafu.de (v6.gruft.de [IPv6:2001:1560:2342::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 9E71D8FC17
	for <freebsd-stable@freebsd.org>; Mon, 23 Feb 2009 11:54:13 +0000 (UTC)
	(envelope-from prvs=0305a14c0b=ob@gruft.de)
Received: from ob by obh.snafu.de with local (Exim 4.69 (FreeBSD))
	(envelope-from <ob@gruft.de>)
	id 1LbZO0-0004GV-Ou; Mon, 23 Feb 2009 12:54:12 +0100
Date: Mon, 23 Feb 2009 12:54:12 +0100
From: Oliver Brandmueller <ob@e-Gitt.NET>
To: freebsd-stable@freebsd.org
Message-ID: <20090223115412.GO79003@e-Gitt.NET>
Mail-Followup-To: freebsd-stable@freebsd.org, Pyun YongHyeon <pyunyh@gmail.com>
References: <20090204100507.5f223d9e.gerrit@pmp.uni-hannover.de>
	<20090204104655.GA73543@michelle.cdnetworks.co.kr>
	<20090205085812.b2deb1f7.gerrit@pmp.uni-hannover.de>
	<20090205082804.GD77461@michelle.cdnetworks.co.kr>
	<20090213101910.a126c14d.gerrit@pmp.uni-hannover.de>
	<20090213102400.GD12653@michelle.cdnetworks.co.kr>
	<20090213114143.a77f1acb.gerrit@pmp.uni-hannover.de>
	<20090213113955.GE12653@michelle.cdnetworks.co.kr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090213113955.GE12653@michelle.cdnetworks.co.kr>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: Oliver Brandmueller <ob@gruft.de>
Cc: Pyun YongHyeon <pyunyh@gmail.com>
Subject: Re: fun with if_re
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2009 11:54:14 -0000

Hi,

On Fri, Feb 13, 2009 at 08:39:55PM +0900, Pyun YongHyeon wrote:
> Ok, try attached patch.

> Index: sys/dev/re/if_re.c
> ===================================================================
> --- sys/dev/re/if_re.c	(revision 187352)
> +++ sys/dev/re/if_re.c	(working copy)
> @@ -158,6 +158,8 @@
>  /* Tunables. */
[...]

This seems to have fixed a regression I found after the latest re 
changes. While the changes lead to a situation, where the re interface 
(as opposed to before) seems to always attach, I had the problem that 
after 1-2 days it failed (sorry, was just about to investigate when I 
tried your patch and thus didn't write down the error message 
associated).

With your patch my re seems to be running fine for the last days now.

re0@pci0:4:0:0: class=0x020000 card=0x392c1462 chip=0x816810ec rev=0x02 hdr=0x00
    vendor     = 'Realtek Semiconductor'
    device     = 'RTL8168/8111 PCI-E Gigabit Ethernet NIC'
    class      = network
    subclass   = ethernet

re0: <RealTek 8168/8168B/8168C/8168CP/8168D/8111B/8111C/8111CP PCIe Gigabit Ethernet> port 0xd800-0xd8ff mem 0xfeaff000-0xfeafffff,0xf8ff0000-0xf8ffffff irq 18 at device 0.0 on pci4
re0: Chip rev. 0x3c000000
re0: MAC rev. 0x00400000
miibus0: <MII bus> on re0
rgephy0: <RTL8169S/8110S/8211B media interface> PHY 1 on miibus0
rgephy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT, 1000baseT-FDX, auto
re0: Ethernet address: 00:21:85:1e:8b:c9
re0: [FILTER]


- Oliver