From owner-svn-src-head@freebsd.org Wed May 3 10:06:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 996E9D5B8D2; Wed, 3 May 2017 10:06:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 251C2F84; Wed, 3 May 2017 10:06:39 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v43A6X8U066204 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 3 May 2017 13:06:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v43A6X8U066204 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v43A6W1w066202; Wed, 3 May 2017 13:06:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 3 May 2017 13:06:32 +0300 From: Konstantin Belousov To: Bruce Evans Cc: emaste@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317681 - head/share/man/man7 Message-ID: <20170503100632.GQ1622@kib.kiev.ua> References: <201705021452.v42EqZSB010115@repo.freebsd.org> <20170503013818.F2099@besplex.bde.org> <20170502174455.GJ1622@kib.kiev.ua> <20170503035045.Q2870@besplex.bde.org> <20170502194525.GL1622@kib.kiev.ua> <20170503153946.M910@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170503153946.M910@besplex.bde.org> User-Agent: Mutt/1.8.2 (2017-04-18) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 10:06:40 -0000 On Wed, May 03, 2017 at 04:19:08PM +1000, Bruce Evans wrote: > On Tue, 2 May 2017, Konstantin Belousov wrote: > OK. > > Including corrections by ngie: > > > diff --git a/share/man/man7/arch.7 b/share/man/man7/arch.7 > > index 1ce397a303e..ad1abccc2e5 100644 > > --- a/share/man/man7/arch.7 > > +++ b/share/man/man7/arch.7 > > @@ -37,6 +37,8 @@ Differences between CPU architectures and platforms supported by > > .Fx . > > .Pp > > This .Pp gives misformatting (an extra blank line) when followed by .Ss. > Apparently, .Ss gives its own paragraph break. > > > .Ss Type sizes > > +If not explicitely mentioned, sizes are in bytes. > > "explicitly" > > This should be moved higher, so that it applies to the "Page Size" section. > The first clause isn't needed, since there are no explicit mentions of > sizes not in bytes (there is only "80 bits" for some FP values which don't > claim to be sizes and aren't really sizes and should be changed to "64 > bits" and claim to be precisions). > > > +.Pp > > Check the formatting after moving the addition higher. There will be 2 > very short paragraphs if you keep this .Pp. Ok, see the cumulative changes in the patch. > > > On all supported architectures, > > The comma at the end of this should be a colon. Ok. > > +.Pp > > +.Sy time_t > > +is always signed, it is 64-bits everywere except on i386 and 32-bit powerpc. > > Change "is always" to "On all supported arches" as elsewhere. > > "everywhere" > > "everywhere" is redundant. Ok. > > The whole second clause is redundant. Remove it. Leave it to the reader > to notice that the table has more 8's than 4's, and where the 4's are. No, this is one of the important reasons why this narrative text added at all. > This also fixes: > - bad grammar (comma splice). In general, use separate sentences, since > the rules for splicing clauses using commas and semicolons or avoiding > these using a word are complicated, though I used splicing in this > sentence to help make it so complicated (IIRC, "since" here is a > splicing method with some technical name like "conjunctive adjective"). > - inconsistent units (bytes in the table and bits here). Ok. diff --git a/share/man/man7/arch.7 b/share/man/man7/arch.7 index 47a72a1986d..62781430329 100644 --- a/share/man/man7/arch.7 +++ b/share/man/man7/arch.7 @@ -36,8 +36,9 @@ Differences between CPU architectures and platforms supported by .Fx . .Pp +If not explicitly mentioned, sizes are in bytes. .Ss Type sizes -On all supported architectures, +On all supported architectures: .Bl -column -offset -indent "long long" "Size" .It Sy Type Ta Sy Size .It short Ta 2 @@ -47,8 +48,10 @@ On all supported architectures, .It float Ta 4 .It double Ta 8 .El -.Bl -column -offset indent "Sy Architecture" "Sy sizeof(void *)" "Sy sizeof(long double)" "Sy sizeof(time_t)" -.It Sy Architecture Ta Sy sizeof(void *) Ta Sy sizeof(long double) Ta Sy sizeof(time_t) +.Pp +Machine-dependent type sizes: +.Bl -column -offset indent "Sy Architecture" "Sy void *" "Sy long double" "Sy time_t" +.It Sy Architecture Ta Sy void * Ta Sy long double Ta Sy time_t .It amd64 Ta 8 Ta 16 Ta 8 .It arm Ta 4 Ta 8 Ta 8 .It armeb Ta 4 Ta 8 Ta 8 @@ -70,6 +73,10 @@ On all supported architectures, .It riscv Ta 8 Ta 16 Ta 8 .It sparc64 Ta 8 Ta 16 Ta 8 .El +.Pp +.Sy time_t +is 8 bytes on all supported architectures except i386 and 32-bit +variants of powerpc. .Ss Endianness and Char Signedness .Bl -column -offset indent "Sy Architecture" "Sy Endianness" "Sy char Signedness" .It Sy Architecture Ta Sy Endianness Ta Sy char Signedness