Date: Mon, 8 Oct 2012 04:59:06 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r305357 - head/net/ssvnc Message-ID: <20121008045905.GD91369@FreeBSD.org> In-Reply-To: <20121008040154.GB91369@FreeBSD.org> References: <201210061123.q96BNHVx053948@svn.freebsd.org> <20121008040154.GB91369@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 08, 2012 at 04:01:54AM +0000, Alexey Dokuchaev wrote: > On Sat, Oct 06, 2012 at 11:23:17AM +0000, Baptiste Daroussin wrote: > > New Revision: 305357 > > URL: http://svn.freebsd.org/changeset/ports/305357 > > > > Log: > > fix sense of a test > > > > -.if ${PORT_OPTIONS:MULTRAFTP} > > +.if empty(PORT_OPTIONS:MULTRAFTP) > > That looks weird, and commit message is pretty cryptic as well. Could you > explain what went wrong here so others would not fall in the same pitfall? Err, I read is as ! vs. empty() test. Still, I've noticved some arguments on the syntax, would be nice to know if ! ${PORT_OPTIONS:M...} has issues other than purely stylish. Thanks, ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121008045905.GD91369>