From owner-cvs-all Mon Oct 7 12:41: 6 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9E3037B401 for ; Mon, 7 Oct 2002 12:41:04 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 338A843E3B for ; Mon, 7 Oct 2002 12:41:04 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 19741 invoked from network); 7 Oct 2002 19:41:04 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 7 Oct 2002 19:41:04 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id g97Jf1n5003184; Mon, 7 Oct 2002 15:41:02 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <22628.1034018839@critter.freebsd.dk> Date: Mon, 07 Oct 2002 15:41:05 -0400 (EDT) From: John Baldwin To: Poul-Henning Kamp Subject: Re: cvs commit: src/sys/boot/i386/btx/btxldr btxldr.s Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 07-Oct-2002 Poul-Henning Kamp wrote: > In message , John Baldwin writes: >> >>On 07-Oct-2002 Poul-Henning Kamp wrote: >>> phk 2002/10/07 12:12:36 PDT >>> >>> Modified files: >>> sys/boot/i386/btx/btxldr btxldr.s >>> Log: >>> Correctly adjust for moved start address. >>> >>> It seems that the existence of a "depend" target in src/sys/boot is not >>> to be taken as an indication that it actually does what one would expect, >>> at least it clearly threw my testing off. >> >>Well, the problem is that the boot code has a lot of indirect magic numbers >>in it and there aren't any real headers that are shared for these various >>things to depend on. This stuff is kind of gross. :) > > I was surprised to see that absolutely no common headers were used, > is there a technical reason for that ? Probably not. Well, the asm code is mostly written with # comments which would all have to be redone if we went with using cpp with these files. We could maybe hack something with m4 at some point. I think I would prefer just biting the bullet and going with cpp at some point. > Otherwise it would be a nice improvement for the future. Agreed. > The good news in all of this is that it will move the 8k barrier > up to 64k so a lot of this code can be written less convoluted once > we get there. We might want to change boot2 to zero it's own bss at some point just to make it happy if possible. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message