From owner-cvs-src@FreeBSD.ORG Wed Sep 8 15:30:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B0B716A4CE; Wed, 8 Sep 2004 15:30:11 +0000 (GMT) Received: from green.homeunix.org (pcp04368961pcs.nrockv01.md.comcast.net [69.140.212.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64C3143D54; Wed, 8 Sep 2004 15:30:10 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i88FU2Co077329; Wed, 8 Sep 2004 11:30:02 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i88FTulu077325; Wed, 8 Sep 2004 11:29:56 -0400 (EDT) (envelope-from green) Date: Wed, 8 Sep 2004 11:29:56 -0400 From: Brian Fundakowski Feldman To: "M. Warner Losh" Message-ID: <20040908152956.GD928@green.homeunix.org> References: <200409080713.i887Dd54058789@repoman.freebsd.org> <20040908.012031.93204322.imp@bsdimp.com> <20040908130741.GC928@green.homeunix.org> <20040908.083215.102654981.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040908.083215.102654981.imp@bsdimp.com> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/usb ugen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2004 15:30:11 -0000 On Wed, Sep 08, 2004 at 08:32:15AM -0600, M. Warner Losh wrote: > In message: <20040908130741.GC928@green.homeunix.org> > Brian Fundakowski Feldman writes: > : On Wed, Sep 08, 2004 at 01:20:31AM -0600, M. Warner Losh wrote: > : > In message: <200409080713.i887Dd54058789@repoman.freebsd.org> > : > Warner Losh writes: > : > : imp 2004-09-08 07:13:39 UTC > : > : > : > : FreeBSD src repository > : > : > : > : Modified files: > : > : sys/dev/usb ugen.c > : > : Log: > : > : Back out 1.88. > : > 1.87 I mean. > : > : The reference counts are there to block detach until the sleepers in > : > : read/write/ioctl have gotten out, not to prevent the open device from > : > : going away. Restore the old behavior so that we have a chance to wake > : > : up sleepers when the usb device goes away, so they can properly return > : > : EIO back to the caller when this happens. > : > : > : > : Otherwise, we have a guarnateed panic waiting to happen when a device > : > : detaches with an active read channel. > : > : > : > : This should be merged to 5 asap. > : > : Now I'll get guaranteed panics using both my Palm and any CardBus hardware. > > Can you send me a traceback for that problem then? The 'reference > count' here is very much supposed to be a 'how many sleepers do you > have' sort of thing and is present in nearly all of the usb drivers. No, I'd prefer not to have to crash my machine more. It already does that (or hangs, or whatever) in -CURRENT often enough. (Holding breath for open sourced Solaris.) -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\