From owner-cvs-src@FreeBSD.ORG Sat Sep 27 13:20:19 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A62A106568F; Sat, 27 Sep 2008 13:20:19 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 181FA8FC17; Sat, 27 Sep 2008 13:20:19 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m8RDKINL097445; Sat, 27 Sep 2008 13:20:18 GMT (envelope-from ed@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m8RDKIj7097399; Sat, 27 Sep 2008 13:20:18 GMT (envelope-from ed@repoman.freebsd.org) Message-Id: <200809271320.m8RDKIj7097399@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to ed@repoman.freebsd.org using -f From: Ed Schouten Date: Sat, 27 Sep 2008 13:19:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_conf.c src/sys/sys systm.h types.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Sep 2008 13:20:19 -0000 ed 2008-09-27 13:19:09 UTC FreeBSD src repository Modified files: sys/kern kern_conf.c sys/sys systm.h types.h Log: SVN rev 183406 on 2008-09-27 13:19:09Z by ed Move uminor() and umajor() to the same place as userspace minor() and major(). The uminor() and umajor() functions have the same use in kernel space as the minor() and major() functions in userspace. If we ever get rid of the minor() function in kernel space, we could decide to just expose minor() and major() to kernel space, making uminor() and umajor() redundant. There are two reasons why we want to have uminor() and umajor() in : - Having them close together prevents them from diverting. Even though it's unlikely the definitions will change, it's a good habit to have them at the same place. - They don't really belong in kern_conf.c. kern_conf.c has been liberated from dealing with device major and minor number handling. The device_ids(9) manpage now lists the wrong #include's, because it should only list now. I'm leaving it as it is now, because I wonder if we should document them anyway. We're probably better off documenting minor(3) and major(3). Revision Changes Path 1.224 +0 -14 src/sys/kern/kern_conf.c 1.269 +0 -2 src/sys/sys/systm.h 1.100 +11 -6 src/sys/sys/types.h