Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 May 2015 21:53:38 +0000
From:      "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org>
To:        freebsd-arm@freebsd.org
Subject:   [Differential] [Commented On] D2378: Introduce ITS support for ARM64
Message-ID:  <426b8efe71e1a7f0e450744b025a17fe@localhost.localdomain>
In-Reply-To: <differential-rev-PHID-DREV-xmqmcfafyun443233vly-req@FreeBSD.org>
References:  <differential-rev-PHID-DREV-xmqmcfafyun443233vly-req@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
emaste added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3_its.c:209-215 Indeed, this is unfortunate. Can you at least KASSERT that it's NULL prior to this assignment and set it to NULL in gic_v3_its_detach to make a failure completely obvious.
  
  How do we expect this to be done later?

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D2378

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, imp, ian, andrew, emaste, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?426b8efe71e1a7f0e450744b025a17fe>