From owner-cvs-all  Mon May 28 13:22:19 2001
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id EB29137B42C; Mon, 28 May 2001 13:22:12 -0700 (PDT)
	(envelope-from phk@FreeBSD.org)
Received: (from phk@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f4SKMCm04588;
	Mon, 28 May 2001 13:22:12 -0700 (PDT)
	(envelope-from phk)
Message-Id: <200105282022.f4SKMCm04588@freefall.freebsd.org>
From: Poul-Henning Kamp <phk@FreeBSD.org>
Date: Mon, 28 May 2001 13:22:12 -0700 (PDT)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/sys/kern tty_pty.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

phk         2001/05/28 13:22:12 PDT

  Modified files:
    sys/kern             tty_pty.c 
  Log:
       With the new kernel dev_t conversions done at release 4.X,
       it becomes possible to trap in ptsstop() in kern/tty_pty.c
       if the slave side has never been opened during the life of a kernel.
  
       What happens is that calls to ttyflush() done from ptyioctl() for the
       controlling side end up calling ptsstop() [via (*tp->t_stop)(tp, <X>)]
       which evaluates the following:
  
  	     struct pt_ioctl *pti = tp->t_dev->si_drv1;
  
       In order for tp->t_dev to be set, the slave device must first be
       opened in ttyopen() [kern/tty.c].
  
       It appears that the only problem is calls to (*tp->t_stop)(tp, <n>),
       so this could also happen with other ioctls initiated by the
       controlling side before the slave has been opened.
  
  PR:		27698
  Submitted by:	David Bein bein@netapp.com
  MFC after:	6 days
  
  Revision  Changes    Path
  1.87      +2 -1      src/sys/kern/tty_pty.c


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message