From owner-freebsd-x11@freebsd.org Tue Mar 14 04:45:16 2017 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8737AD0B174 for ; Tue, 14 Mar 2017 04:45:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 70A2F1208 for ; Tue, 14 Mar 2017 04:45:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 6D0F0D0B171; Tue, 14 Mar 2017 04:45:16 +0000 (UTC) Delivered-To: x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6CA82D0B16F for ; Tue, 14 Mar 2017 04:45:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5BD831207 for ; Tue, 14 Mar 2017 04:45:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2E4jGog023194 for ; Tue, 14 Mar 2017 04:45:16 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: [Bug 217771] lang/beignet: update to 1.3.1 Date: Tue, 14 Mar 2017 04:45:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 04:45:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217771 --- Comment #7 from Jan Beich (mail not working) --- Comment on attachment 180799 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D180799 update lang/beignet to 1.3.1 OpenCL 2.0 requires LLVM >=3D 3.9 and libdrm >=3D 2.4.67 (i.e. ports r43146= 3 and maybe[1] drm-next). I forgot to adjust at least BUILD_DEPENDS in my version. [1] Whether drm_intel_bo_set_softpin_offset() works on FreeBSD 10.3 or 11.0= or causes a crash similar to bug 217635 is unknown. https://cgit.freedesktop.org/mesa/drm/commit/?id=3D8b4d57e7=20=20 > +OPTIONS_DEFINE=3D FP64 TEST > +FP64_DESC=3D Double precision (experimental) I don't like this style of grouping as it doesn't scale. If you have many options having to jump between descriptions and definitions when working on= a port with many can get tiring, see multimedia/ffmpeg. > +.if ${ARCH} =3D=3D amd64 > +PLIST_SUB+=3D OCL20=3D"" > +.else # ${ARCH} =3D=3D i386 > +PLIST_SUB+=3D OCL20=3D"@comment " > +.endif Conditionals break (mostly) declarative style of makefiles. Try the followi= ng instead PLIST_SUB+=3D OCL20=3D"${ARCH:Namd64:C/.+/@comment /}" > + -@(cd ${TEST_WRKSRC}.utests; . ./setenv.sh; \ Why do you need to introduce typos? $ make test WITH=3DTEST =3D=3D=3D> Testing for beignet-1.3.1 cd: /usr/ports/lang/beignet/work/Beignet-1.3.1-Source.utests: No such fil= e or directory .: cannot open ./setenv.sh: No such file or directory *** Error code 2 (ignored) $ make test WITH=3DTEST =3D=3D=3D> Testing for beignet-1.3.1 /bin/sh: ./flataddress_space: not found > +- src_data =3D (uint32_t*)memalign(base_address_alignment, buffer_sz); > +- if(!src_data) { > ++ if(posix_memalign((void**)&src_data, base_address_alignment, buffer_s= z)) { posix_memalign has greater minimal alignment than memalign or aligned_alloc= in jemalloc and glibc. And neither memalign nor posix_memalign are available on Windows. Or do you have something against using C11/C++17 features without passing corresponding -std=3D ? https://github.com/jemalloc/jemalloc/blob/4.5.0/src/jemalloc.c#L2038 https://github.com/jemalloc/jemalloc/blob/4.5.0/src/jemalloc.c#L1787 https://sourceware.org/git/?p=3Dglibc.git;a=3Dblob;f=3Dmalloc/malloc.c;hb= =3Dglibc-2.25#l3071 https://sourceware.org/git/?p=3Dglibc.git;a=3Dblob;f=3Dmalloc/malloc.c;hb= =3Dglibc-2.25#l3136 > @@ -17,7 +17,7 @@ >=20=20 > # XLib > Find_Package(X11) > -@@ -219,7 +218,7 @@ IF(OCLIcd_FOUND) > +@@ -217,7 +216,7 @@ IF(OCLIcd_FOUND) > "intel-beignet.icd.in" > "${ICD_FILE_NAME}" > ) Try to avoid excessive noise (e.g. line offsets, timestamps) in patches. > @@ -29,6 +29,8 @@ > lib/beignet/include/ocl_vload_20.h > lib/beignet/include/ocl_work_group.h > lib/beignet/include/ocl_workitem.h > +%%OCL20%%lib/beignet/beignet_20.bc > +%%OCL20%%lib/beignet/beignet_20.pch > lib/beignet/libcl.so > lib/beignet/libgbe.so > lib/beignet/libgbeinterp.so Keep sorting consistent with a version where %% macros are expanded. --=20 You are receiving this mail because: You are the assignee for the bug.=