From owner-freebsd-stable@FreeBSD.ORG Thu Nov 19 18:48:11 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 467471065676 for ; Thu, 19 Nov 2009 18:48:11 +0000 (UTC) (envelope-from matthew.fleming@isilon.com) Received: from seaxch09.isilon.com (seaxch09.isilon.com [74.85.160.25]) by mx1.freebsd.org (Postfix) with ESMTP id 2A5C08FC08 for ; Thu, 19 Nov 2009 18:48:11 +0000 (UTC) x-mimeole: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Date: Thu, 19 Nov 2009 10:48:40 -0800 Message-ID: <06D5F9F6F655AD4C92E28B662F7F853E03390417@seaxch09.desktop.isilon.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: LRO support for cxgb in stable/7 Thread-Index: AcppSOmBX6UuOkplRauuMBXFB4pgtg== From: "Matthew Fleming" To: Cc: gnn@freebsd.org Subject: LRO support for cxgb in stable/7 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2009 18:48:11 -0000 r193754 to stable/7 appears to have unintended code. The MFC note indicates it is a backport of 190206, 190330, 192537, 192540, 192584 and 192933. I looked over all of them and none have the offending snippet: #ifndef LRO_SUPPORTED #ifdef IFCAP_LRO #undef IFCAP_LRO #endif #define IFCAP_LRO 0x0 #endif cxgb had LRO support on releng/7.1 and now it does not, since LRO_SUPPORTED is not defined anywhere as a config option, or in the cxgb Makefile. Is this analysis correct? Should the above lines be deleted from the stable/7 repository? Thanks, matthew