From owner-freebsd-x11@FreeBSD.ORG  Thu Feb 13 22:36:21 2014
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
Delivered-To: freebsd-x11@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1A30C983
 for <freebsd-x11@freebsd.org>; Thu, 13 Feb 2014 22:36:21 +0000 (UTC)
Received: from master.debian.org (master.debian.org
 [IPv6:2001:41b8:202:deb:216:36ff:fe40:4001])
 (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id CD0ED1BD7
 for <freebsd-x11@freebsd.org>; Thu, 13 Feb 2014 22:36:20 +0000 (UTC)
Received: from localhost ([::1]) by master.debian.org with esmtp (Exim 4.80)
 (envelope-from <rmh@freebsd.org>)
 id 1WE4tH-0000iN-50; Thu, 13 Feb 2014 22:36:19 +0000
Message-ID: <52FD48E2.3060408@freebsd.org>
Date: Thu, 13 Feb 2014 22:36:18 +0000
From: Robert Millan <rmh@freebsd.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Alex Kozlov <spam@rm-rf.kiev.ua>
Subject: Re: [PATCH] do not feed keyboard device path in X devd backend
References: <52EFA9A9.2040901@freebsd.org> <52F61969.2060503@freebsd.org>
 <20140208135404.GA75736@ravenloft.kiev.ua> <52F63866.80505@freebsd.org>
 <20140209102615.GA11713@ravenloft.kiev.ua> <52FCEC09.8080409@freebsd.org>
 <20140213162822.GA5118@ravenloft.kiev.ua> <52FD39F8.5090708@freebsd.org>
 <20140213215257.GA12243@ravenloft.kiev.ua>
In-Reply-To: <20140213215257.GA12243@ravenloft.kiev.ua>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-x11@freebsd.org
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11/>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Feb 2014 22:36:21 -0000

On 13/02/2014 21:52, Alex Kozlov wrote:
> On Thu, Feb 13, 2014 at 09:32:40PM +0000, Robert Millan wrote:
>> On 13/02/2014 16:28, Alex Kozlov wrote:
>>>> [  1002.547] (EE) Keyboard: cannot open "/dev/ukbd0"
>>>> [  1002.547] (EE) PreInit returned 8 for "Keyboard"
>>>> [  1002.547] (II) UnloadModule: "kbd"
>>> This should be worked around by the next code:
>>>
>>> 269 +    if (attrs.flags & ATTR_KEYBOARD) {
>>> 270 +      /*
>>> 271 +       * Don't pass device option if keyboard is attached to console (open fails),
>>> 272 +       * thus activating special logic in xf86-input-keyboard.
>>> 273 +       */
>>> 274 +       fd = open(path, O_RDONLY | O_NONBLOCK | O_EXCL);
>>> 275 +       if (fd > 0) {
>>> 276 +          close(fd);
>>> 277 +          options = input_option_new(options, "device", path);
>>> 278 +       }
>>> 279 +    } else {
>>> 280 +          options = input_option_new(options, "device", path);
>>> 281 +    }
>>
>> Where's this code? I can't see it in x11-servers/xorg-server/files/extra-config_devd.c
> http://trillian.chruetertee.ch/ports/browser/trunk/x11-servers/xorg-server/files/extra-devd
> plus
> http://trillian.chruetertee.ch/ports/browser/trunk/x11-servers/xorg-server/files/extra-new-config_devd
>  
> You need revision 1282 of x11-servers/xorg-server.

Great. Looks like I wasted several hours of work by debugging the wrong branch...

-- 
Robert Millan