From owner-svn-src-head@freebsd.org Mon Jul 23 20:43:57 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED1641054A40 for ; Mon, 23 Jul 2018 20:43:56 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7ADDB8E298 for ; Mon, 23 Jul 2018 20:43:56 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: 1cc1dd29-8eb9-11e8-904b-1d2e466b3c59 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id 1cc1dd29-8eb9-11e8-904b-1d2e466b3c59; Mon, 23 Jul 2018 20:43:54 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w6NKhrwE013830; Mon, 23 Jul 2018 14:43:53 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1532378633.1344.190.camel@freebsd.org> Subject: Re: svn commit: r336619 - head/lib/libc/gen From: Ian Lepore To: Cy Schubert Cc: Alan Somers , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Date: Mon, 23 Jul 2018 14:43:53 -0600 In-Reply-To: <201807232011.w6NKBqgT050306@slippy.cwsent.com> References: <201807232011.w6NKBqgT050306@slippy.cwsent.com> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 20:43:57 -0000 On Mon, 2018-07-23 at 13:11 -0700, Cy Schubert wrote: > In message <1532364679.1344.161.camel@freebsd.org>, Ian Lepore > writes: > > > > On Mon, 2018-07-23 at 09:41 -0700, Cy Schubert wrote: > > > > > > I'm sure. Rolling this libc commit back addressed the ssh > > > segfaults > > > on all my systems. > > > > > > --- > > > Sent using a tiny phone keyboard. > > > Apologies for any typos and autocorrect. > > > Also, this old phone only supports top post. Apologies. > > > > > > Cy Schubert > > > or > > > The need of the many outweighs the greed of the few. > > > --- > > > > > My current working theory is that some of the software that uses > > __pw_scan() pre-stages a pointer-to-empty-string into the pw_class > > field and my change ruined that by replacing it with a NULL > > pointer. > > Other callers of __pw_scan() don't do that, they just assume > > they're > > running as root and will get all the fields populated. > Yes. A simple check for pw->pw_class != NULL should fix this > instance. Oh, or... if you meant tracking down all callers of __pw_scan() and making them conform to the possibility that the pointer got changed to NULL, I don't think I want to do that. If I was going to get into examining all callers of __pw_scan() and fixing them, I'd want to make them all use the pw_fields bits (but then that means tracking down all the ways a pwd struct can get created or filled in and fixing them as well, and suddenly you're on a new career path). -- Ian