From owner-freebsd-bugs@FreeBSD.ORG Sun Mar 16 15:20:03 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BDFE1065675 for ; Sun, 16 Mar 2008 15:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 755B88FC17 for ; Sun, 16 Mar 2008 15:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2GFK3ul061461 for ; Sun, 16 Mar 2008 15:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m2GFK3DL061454; Sun, 16 Mar 2008 15:20:03 GMT (envelope-from gnats) Resent-Date: Sun, 16 Mar 2008 15:20:03 GMT Resent-Message-Id: <200803161520.m2GFK3DL061454@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Richard Arends Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9ACC41065670 for ; Sun, 16 Mar 2008 15:16:09 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id A64908FC12 for ; Sun, 16 Mar 2008 15:16:09 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m2GFCiMR051458 for ; Sun, 16 Mar 2008 15:12:44 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m2GFCiP1051457; Sun, 16 Mar 2008 15:12:44 GMT (envelope-from nobody) Message-Id: <200803161512.m2GFCiP1051457@www.freebsd.org> Date: Sun, 16 Mar 2008 15:12:44 GMT From: Richard Arends To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/121763: TinyBSD remove_workdir function needs some extra checking for existing mounts X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Mar 2008 15:20:03 -0000 >Number: 121763 >Category: misc >Synopsis: TinyBSD remove_workdir function needs some extra checking for existing mounts >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Mar 16 15:20:03 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Richard Arends >Release: 7.0-RELEASE >Organization: unixguru.nl >Environment: FreeBSD tinybsd.unixguru.nl 7.0-STABLE FreeBSD 7.0-STABLE #1: Sun Mar 16 11:17:33 CET 2008 root@tinybsd.unixguru.nl:/usr/obj/usr/src/sys/GENERIC i386 >Description: If a tinybsd build is interrupted and later started again, there's a possibility that directory's are still mounted with mount_nullfs. Running the remove_workdir function can than do severe damage to the build host, because it wil remove anything below $WORKDIR, thus also the mounted directory's like /lib. ..oops.. >How-To-Repeat: Interupt a tinybsd build at the time it is building the (optional) ports. Then start it again and the remove_workdir function will delete everything under $WORKDIR, >Fix: Apply the patch Patch attached with submission follows: --- tinybsd 2008-03-16 09:28:42.000000000 +0100 +++ tinybsd.new 2008-03-16 15:44:33.000000000 +0100 @@ -248,12 +248,21 @@ } remove_workdir() { - chflags -R noschg ${WORKDIR} - echo "${TS} Removing "${WORKDIR} - rm -rf ${WORKDIR} - echo "${TS} Removing Build Kernel Directory" - rm -rf /usr/obj/usr/src/sys/${KERNCONF} - echo "${TS} done." + # Before removing check if there is not a mount under $WORKDIR anymore + MOUNT_CHECK=`mount|egrep "on ${WORKDIR}"` + + if [ ! -z "${MOUNT_CHECK}" ]; then + echo "There are mounts under the workdir (${WORKDIR}). Please umount them before running this script" + exit 1 + else + exit 11 + chflags -R noschg ${WORKDIR} + echo "${TS} Removing "${WORKDIR} + rm -rf ${WORKDIR} + echo "${TS} Removing Build Kernel Directory" + rm -rf /usr/obj/usr/src/sys/${KERNCONF} + echo "${TS} done." + fi } >Release-Note: >Audit-Trail: >Unformatted: