From owner-freebsd-bugs  Tue Mar 12 17:30: 8 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 8AFBE37B417
	for <freebsd-bugs@hub.freebsd.org>; Tue, 12 Mar 2002 17:30:02 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g2D1U2f38806;
	Tue, 12 Mar 2002 17:30:02 -0800 (PST)
	(envelope-from gnats)
Received: from xkulesh.vol.cz (xkulesh.vol.cz [195.250.154.106])
	by hub.freebsd.org (Postfix) with ESMTP id 8D5D837B400
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Mar 2002 17:21:26 -0800 (PST)
Message-Id: <200203130113.g2D1DD970719@xkulesh.vol.cz>
Date: Wed, 13 Mar 2002 02:13:13 +0100 (CET)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: bin/35836: Typo in ppp's mppe.c MPPEDispOpts output
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         35836
>Category:       bin
>Synopsis:       Typo in ppp's mppe.c MPPEDispOpts output
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 12 17:30:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Dan Lukes
>Release:        FreeBSD 4.5-STABLE i386
>Organization:
Obludarium
>Environment:
System: FreeBSD 4.5-STABLE Sat Mar 2 15:16:06 CET 2002 dan@...:/usr/src/sys/compile/Dan i386

PPP: user-ppp 2.3.3 (built Mar  2 2002)

	
>Description:
	The MPPEDispOpts incorrectly build description string when no
encryption requested by peer. It add "(0" string to buffer, but add 1 only
to buffer len, so '0' is overwritten by subsequent writes.
>How-To-Repeat:
	enable CCP logging and connect to a PPP peer asking MPPC without
MPPE (it's implemented as ask for MPPE with MPPE_OPT_COMPRESSED bit set 
but all MPPE_OPT_BITMASK bits cleared
>Fix:

--- mppe.c.ORIG Sun Sep  2 06:08:33 2001
+++ mppe.c      Wed Mar 13 01:48:43 2002
@@ -372,7 +372,7 @@
   len = strlen(buf);
   if (!(val & MPPE_OPT_BITMASK)) {
     snprintf(buf + len, sizeof buf - len, "(0");
-    len++;
+    len+=2;
   } else {
     ch = '(';
     if (val & MPPE_OPT_128BIT) {



>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message