From owner-svn-src-head@freebsd.org Mon Sep 19 22:13:53 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4164BE0EC2; Mon, 19 Sep 2016 22:13:53 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A3B7220E; Mon, 19 Sep 2016 22:13:53 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f182.google.com with SMTP id m79so2010676ioo.3; Mon, 19 Sep 2016 15:13:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=PDQyOijl4S+L5+YhUiFTrjD3Rqty/5anCFaKVQb6kus=; b=Ke5ALbYARFIHrSs7BGZM8+rjnXdV2U1IYEetPao/TIuhtr/ZVirIjGjdqh4Xaj/1uj qinQ3Hcq8+1PYJqzvGyDdkdGwQqcF7LRc+UDi6EpLQ03a7h72sUX2ZqDUwSJ9ESc/2XS iJ55U0niKgFbGfLWH06AHh7jWHnUMVfFZD0NNodHLmFYFDBNw7/gbTF0iiZtGWukfFt9 V1Q2pKQRiOeMDnFNm1tIDHXC0tTQ2sEDwa8iwP/B1ngUdKy4nscOfoesRx7FmTo9hdmB B+Y+achOLAm7Gq/yhEZrB6XcoZMmIbJScD25JWyezaHFKb1T8LzkEbfpnxHLI5CAcTnV o67g== X-Gm-Message-State: AE9vXwMjyl46TJlbcPuUKeCoQl+M15SuZaDn62r9Hg93A1ygqg9uNTXdFtHBtR+Qb/HTVA== X-Received: by 10.107.169.202 with SMTP id f71mr3343601ioj.161.1474318986703; Mon, 19 Sep 2016 14:03:06 -0700 (PDT) Received: from mail-io0-f181.google.com (mail-io0-f181.google.com. [209.85.223.181]) by smtp.gmail.com with ESMTPSA id y133sm9611935ioy.8.2016.09.19.14.03.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Sep 2016 14:03:06 -0700 (PDT) Received: by mail-io0-f181.google.com with SMTP id r145so614661ior.0; Mon, 19 Sep 2016 14:03:06 -0700 (PDT) X-Received: by 10.107.21.129 with SMTP id 123mr37340624iov.72.1474318986180; Mon, 19 Sep 2016 14:03:06 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.220.129 with HTTP; Mon, 19 Sep 2016 14:03:05 -0700 (PDT) In-Reply-To: References: <201609192043.u8JKh3jv040006@repo.freebsd.org> From: Conrad Meyer Date: Mon, 19 Sep 2016 14:03:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r305998 - in head/usr.bin: cmp indent tr To: "Ngie Cooper (yaneurabeya)" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 22:13:53 -0000 If you re-read the sentences you've pasted carefully, I think you'll find it doesn't actually say that the types or param headers come before other sys/ headers. Just that sys/ headers come before non-sys/ headers. Best, Conrad On Mon, Sep 19, 2016 at 1:45 PM, Ngie Cooper (yaneurabeya) wrote: > > On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer wrote: > > Author: cem > Date: Mon Sep 19 20:43:03 2016 > New Revision: 305998 > URL: https://svnweb.freebsd.org/changeset/base/305998 > > Log: > Move sys/capsicum.h includes after types.h or param.h > > This is not actually documented or even implied in style(9). Make the > change > to match convention. Someone should document this convention in style(9= ). > > Reported by: jhb > Sponsored by: EMC Dell Isilon > > > Uh=E2=80=A6 yes it clearly states it in style(9). From > https://www.freebsd.org/cgi/man.cgi?query=3Dstyle&sektion=3D9 : > > Kernel include files (i.e. sys/*.h) come first; normally, include > OR , but not both. include= s > , and it is okay to depend on that. > > Thanks, > -Ngie