Date: Mon, 24 Apr 2006 14:05:48 -0700 From: Jeremy Chadwick <freebsd@jdc.parodius.com> To: Kris Kennaway <kris@obsecurity.org> Cc: cvs-ports@FreeBSD.org, "Andrey A. Chernov" <ache@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/png/files patch-aa Message-ID: <20060424210548.GA80839@pentarou.parodius.com> In-Reply-To: <20060424180431.GA13567@xor.obsecurity.org> References: <200604241404.k3OE49eJ074318@repoman.freebsd.org> <20060424180431.GA13567@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 24, 2006 at 02:04:31PM -0400, Kris Kennaway wrote:
> On Mon, Apr 24, 2006 at 02:04:09PM +0000, Andrey A. Chernov wrote:
> > ache 2006-04-24 14:04:09 UTC
> >
> > FreeBSD ports repository
> >
> > Modified files:
> > graphics/png/files patch-aa
> > Log:
> > Use NO_OBJ NO_PROFILE instead of obsoleted their variants
> >
> > PR: 96244
> > Submitted by: Jeremy Chadwick <freebsd@jdc.parodius.com>
>
> Are you sure this works on old FreeBSD branches?
No, I did not test this.
Kris is right -- chances are it won't suffice for 4.x. The modified
port builds fine on my 4.x box, but obviously the ports/mk framework
is expecting NOOBJ and NOPROFILE there. I don't know of a way to
test this (not sure what NOOBJ does, and profiling is completely
disabled on all of my machines).
One solution for solving this dilemma would be to remove the NOOBJ
and NOPROFILE lines completely from ${WRKSRC}/scripts/makefile.freebsd
and utilise a check in the port Makefile for ${OSVERSION}, e.g.
something like this:
.if ${OSVERSION} < 500000
MAKE_ARGS+= -DNOPROFILE -DNOOBJ
.else
MAKE_ARGS+= -DNO_PROFILE -DNO_OBJ
.endif
I can come up with a diff/patch for this if need be, since I'm the
one responsible for submitting this PR in the first place...
--
| Jeremy Chadwick jdc at parodius.com |
| Parodius Networking http://www.parodius.com/ |
| UNIX Systems Administrator Mountain View, CA, USA |
| Making life hard for others since 1977. |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060424210548.GA80839>