From owner-freebsd-xfce@FreeBSD.ORG Tue Nov 5 06:10:39 2013 Return-Path: Delivered-To: freebsd-xfce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3A41260F for ; Tue, 5 Nov 2013 06:10:39 +0000 (UTC) (envelope-from duchateau.olivier@gmail.com) Received: from mail-lb0-x235.google.com (mail-lb0-x235.google.com [IPv6:2a00:1450:4010:c04::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B9E432DFC for ; Tue, 5 Nov 2013 06:10:38 +0000 (UTC) Received: by mail-lb0-f181.google.com with SMTP id x18so6109243lbi.40 for ; Mon, 04 Nov 2013 22:10:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=NcU/DqZ2L8a4QvK0EOT6QIBeZmcglGWCHZBkngepwW8=; b=ZAMtVvfkLWX3OPRYk1qVXpObNgV+0w0fBVcpLs0vCttlwvF8Psu4KMPfSSeGOBK0cI j2ju+HNkcoxThxLjVUYPbetslt5La+vxOaH3v0o1XNofHCArqIWmSORRp1OM0eL4Tsk6 2i2449RRK6kWbKelx+DKBwJJitzM9+CVMeL7ke4chh4ruejIbiuHSBKbRvheIk0Be3Ua eKoTdiQ/4aIkN9SxPiEKTwaQNJJ3TVsttfzdYIKkBMDbeDHGRw7LVjVmxJFQUDHvY8RU iIEJGRzeb4Z7zzyxfadWl1ZwEtUGQZZ6LXAH1DknddwkWCBw9v8caATjyujMN6VkVcS4 ccOA== MIME-Version: 1.0 X-Received: by 10.152.235.40 with SMTP id uj8mr328422lac.39.1383631836828; Mon, 04 Nov 2013 22:10:36 -0800 (PST) Received: by 10.152.9.8 with HTTP; Mon, 4 Nov 2013 22:10:36 -0800 (PST) In-Reply-To: References: Date: Tue, 5 Nov 2013 07:10:36 +0100 Message-ID: Subject: Re: vendorinfo file From: Olivier Duchateau To: Rostislav Krasny Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-xfce@freebsd.org X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Nov 2013 06:10:39 -0000 2013/11/5 Rostislav Krasny : > On Tue, Nov 5, 2013 at 12:45 AM, Rostislav Krasny wrote: >> On Tue, Nov 5, 2013 at 12:22 AM, Olivier Duchateau >>> See commit log, here >>> http://git.xfce.org/xfce/libxfce4ui/commit/xfce4-about/main.c?id=4a14ef81cdc6f3e45b63eb42ca41c6af50c9c0c4 >> >> See the full version of this file. If the VENDOR_INFO macro isn't >> defined, all that vendor specified code is disabled. >> >> http://git.xfce.org/xfce/libxfce4ui/tree/xfce4-about/main.c >> >> And according to libxfce4ui/tree/configure.ac.in the VENDOR_INFO seems >> to be defined only when '--with-vendor-info' is used with some not >> empty value. > > Finally I tested it by changes attached in the libxfce4menu.diff file. > After this change the xfce4-about program shows no vendor information > (neither vendor name in the version text nor vendor tab) and doesn't > print any warning in the console it is ran from. > > I don't insist in this change. If you want to keep > '--with-vendor-info=FreeBSD' and to add some vendorinfo file with > FreeBSD about and advertising information, it would be nice too. Just > make a choice. I disagree with you, new tab will be created if length of file is greater than zero. If file doesn't exists or is empty nothing append (see xfce_about_vendor() function). --with-vendor-info=FreeBSD is used in main() function (from line 482) as xfce_about_vendor() doesn't initialize new tab, OS is only display. -- olivier