From owner-freebsd-stable@FreeBSD.ORG Tue Feb 2 20:37:58 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99F0D1065694 for ; Tue, 2 Feb 2010 20:37:58 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.8]) by mx1.freebsd.org (Postfix) with ESMTP id 4C5D78FC1D for ; Tue, 2 Feb 2010 20:37:56 +0000 (UTC) Received: from vampire.homelinux.org (dslb-088-064-184-208.pools.arcor-ip.net [88.64.184.208]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0Mb2zL-1NJUwi0wDz-00K6TN; Tue, 02 Feb 2010 21:37:55 +0100 Received: (qmail 17145 invoked from network); 2 Feb 2010 20:37:54 -0000 Received: from f8x64.laiers.local (192.168.4.188) by laiers.local with SMTP; 2 Feb 2010 20:37:54 -0000 From: Max Laier Organization: FreeBSD To: freebsd-stable@freebsd.org Date: Tue, 2 Feb 2010 21:37:51 +0100 User-Agent: KMail/1.12.4 (FreeBSD/8.0-RELEASE-p2; KDE/4.3.4; amd64; ; ) References: <147432021001310037n1b67f01bx4b4e8781321cea8@mail.gmail.com> <20100202173746.GA5901@michelle.cdnetworks.com> <2a41acea1002020948l6f3d1a08v9f4ccefd1241f566@mail.gmail.com> In-Reply-To: <2a41acea1002020948l6f3d1a08v9f4ccefd1241f566@mail.gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201002022137.52064.max@love2party.net> X-Provags-ID: V01U2FsdGVkX19I56Mr2mQwD7B9J6yO1+cHHFEavOGN8q42Ut7 Byb3PPPLYCeXMw4g+d1WcI2GX90ApPyemY9KxODs7TBncBm/w3 dBnmsA/eOAwGdeU94FNjg== Cc: pyunyh@gmail.com, Nick Rogers , stable@freebsd.org, jfv@freebsd.org, Jack Vogel Subject: Re: em(4) + ALTQ broken X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2010 20:37:58 -0000 On Tuesday 02 February 2010 18:48:02 Jack Vogel wrote: > So apparently this thing needs no special knowledge in the driver, yet > something in > the new code breaks it, can someone explain tersely how the altq app > actually > "pokes" or "hooks up" to the driver? I am not clear about that and I > suspect if I was > this would all be clearer. The whole story is in man 9 altq long story short, as long as you consistently use the IFQ_* macros to manage the interface queue, things should just work. if_var.h used to conditionally define these macros to avoid ALTQ overhead when the kernel is built without ALTQ. This has changed a long time ago and should not make any difference anymore. I can't figure out who the OP is, but could you make sure that the includes that are used to built the kernel are up to date? You are building with the buildkernel target and not "the old way", right? Also, if you build just the module, the build might pick up the includes from /usr/include instead of src/sys ... > Jack > > On Tue, Feb 2, 2010 at 9:37 AM, Pyun YongHyeon wrote: > > On Tue, Feb 02, 2010 at 09:30:52AM -0800, Nick Rogers wrote: > > > > I guess the problem comes from multi-queue support. The drbr > > > > interface is implemented with inline function so em(4)/igb(4) may > > > > have to define ALTQ to the header. I have not tested the patch(no > > > > time at this moment) but would you give it try? > > > > > > > > I tried the patch and it did not work. > > > > You rebuilt kernel, right? Rebuilding kernel module has no effect. > > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" > > > !DSPAM:4b686584144321871135632! >