From owner-freebsd-bugs  Sat Oct 14  0: 0:10 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2C14137B66D
	for <freebsd-bugs@FreeBSD.org>; Sat, 14 Oct 2000 00:00:06 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id AAA94315;
	Sat, 14 Oct 2000 00:00:06 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from spock.org (cm-24-169-0-39.nycap.rr.com [24.169.0.39])
	by hub.freebsd.org (Postfix) with ESMTP id AE6AB37B503
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 13 Oct 2000 23:57:24 -0700 (PDT)
Received: (from jon@localhost)
	by spock.org  serial EF600Q3T-B7F;
	Sat, 14 Oct 2000 02:57:18 -0400 (EDT)
	(envelope-from jon)
Message-Id: <200010140657.e9E6vIp07839@spock.org>
Date: Sat, 14 Oct 2000 02:57:18 -0400 (EDT)
From: Jonathan Chen <jon@spock.org>
Reply-To: jon@spock.org
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/21982: makedevops.pl HEADER section doesn't quite work
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         21982
>Category:       kern
>Synopsis:       makedevops.pl HEADER section doesn't quite work
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 14 00:00:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Jonathan Chen
>Release:        all
>Organization:
>Environment:

	

>Description:

The HEADER section was introduced to sys/kern/makedevops.pl (1.10) by
n_hibma.  The name seems to suggest a section that would be generated into
the header file.  It doesn't do that.  Note that no existing .m files use
the HEADER section.

>How-To-Repeat:
echo > foo_if.m << EOF
INTERFACE foo;
HEADER {
  /* this should be in the header */
};
EOF
perl5 -w /usr/src/sys/kern/makedevops.pl -h foo_if.m

>Fix:

Index: sys/kern/makedevops.pl
===================================================================
RCS file: /export/ncvs/src/sys/kern/makedevops.pl,v
retrieving revision 1.12
diff -u -r1.12 makedevops.pl
--- sys/kern/makedevops.pl	1999/11/22 14:40:04	1.12
+++ sys/kern/makedevops.pl	2000/10/14 06:55:55
@@ -249,7 +249,7 @@
             $lineno++
          }
          if ( $hfile ) {
-             print CFILE $header;
+             print HFILE $header;
          }
       } elsif ( $line =~ m/^(STATIC|)METHOD/i ) {
          # Get the return type function name and delete that from

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message