From owner-freebsd-ports@FreeBSD.ORG Fri Jul 22 17:46:38 2005 Return-Path: X-Original-To: freebsd-ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AAC2016A41F; Fri, 22 Jul 2005 17:46:38 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5A5D44E8A; Fri, 22 Jul 2005 17:46:37 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 601DC11D44; Fri, 22 Jul 2005 19:49:31 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 09924-03; Fri, 22 Jul 2005 19:49:25 +0200 (CEST) Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6]) by smtp.xbsd.org (Postfix) with ESMTP id 4B8D411BAA; Fri, 22 Jul 2005 19:49:25 +0200 (CEST) From: Florent Thoumie To: Jeremie Le Hen In-Reply-To: <20050722173215.GR39292@obiwan.tataz.chchile.org> References: <20050722150032.GP39292@obiwan.tataz.chchile.org> <1122050545.97024.2.camel@cream.xbsd.org> <20050722173215.GR39292@obiwan.tataz.chchile.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-3oCjyX5KaUE8O5UpcyBR" Date: Fri, 22 Jul 2005 19:46:35 +0200 Message-Id: <1122054396.97024.7.camel@cream.xbsd.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-ports@FreeBSD.org, edwin@FreeBSD.org Subject: Re: ngrep and libpcap from ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2005 17:46:38 -0000 --=-3oCjyX5KaUE8O5UpcyBR Content-Type: text/plain; charset=iso8859-15 Content-Transfer-Encoding: quoted-printable Le Vendredi 22 juillet 2005 =E0 19:32 +0200, Jeremie Le Hen a =E9crit : > Florent, >=20 > > > This patch will link against the libpcap from ports if it exists. > > > I'm not sure this is the correct way to write this, feel free to chan= ge > > > it's needed. > >=20 > > I wouldn't fix it that way because it would lead to unexpected=20 > > behavior. > >=20 > > I'd use base pcap includes unless WITH_PORTS_PCAP is defined=20 > > (which add pcap to LIB_DEPENDS). >=20 > Thanks for your reply. I'll take it as the way to go it as I'm > convinced you are far more experienced in ports than I am. >=20 > Here is the updated patch. Note nevertheless that adding > --with-pcap-includes=3D${PREFIX}/include > to CONFIGURE_ARGS is required or ngrep configure script will fail > miserably with the message I showed in my previous mail. >=20 > Regards, Still won't work for you (or people who have libpcap installed=20 from ports and doesn't have WITH_PORTS_LIBPCAP). Something like this would be more appropriate : .if !defined(WITH_PORTS_LIBPCAP) # Default behavior CONFIGURE_ARGS+=3D --with-pcap-includes=3D/usr/include .else CONFIGURE_ARGS+=3D --with-pcap-includes=3D${PREFIX}/include LIB_DEPENDS=3D pcap.2:${PORTSDIR}/net/libpcap .endif --=20 Florent Thoumie flz@xbsd.org --=-3oCjyX5KaUE8O5UpcyBR Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBC4TD7MxEkbVFH3PQRAoVAAJ9eChw/r8pgMGxBKjfgtFsc0N8clQCffOa3 sqz+DHE/GkuLIfMTIqhRdFg= =zQi3 -----END PGP SIGNATURE----- --=-3oCjyX5KaUE8O5UpcyBR--