From owner-freebsd-bugs Wed Nov 20 2:24:28 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 297EF37B401 for ; Wed, 20 Nov 2002 02:24:27 -0800 (PST) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51C4743E4A for ; Wed, 20 Nov 2002 02:24:25 -0800 (PST) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 3939151900; Wed, 20 Nov 2002 20:35:13 +1030 (CST) Date: Wed, 20 Nov 2002 20:35:13 +1030 From: Greg 'groggy' Lehey To: Bruce Evans Cc: freebsd-bugs@FreeBSD.org Subject: Re: misc/45493: Confusing comment in /etc/crontab Message-ID: <20021120100513.GM63395@wantadilla.lemis.com> References: <200211200640.gAK6e3NS064712@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200211200640.gAK6e3NS064712@freefall.freebsd.org> User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Tuesday, 19 November 2002 at 22:40:03 -0800, Bruce Evans wrote: > The following reply was made to PR misc/45493; it has been noted by GNATS. > > From: Bruce Evans > To: Kevin Oberman > Cc: FreeBSD-gnats-submit@FreeBSD.ORG > Subject: Re: misc/45493: Confusing comment in /etc/crontab > Date: Wed, 20 Nov 2002 17:47:26 +1100 (EST) > > On Tue, 19 Nov 2002, Kevin Oberman wrote: > >>> Description: >> The comment for the adjkerntz entry in /etc/crontab is not >> clear. The comma usage makes it unclear which cadse is the accepted >> and which is rejected. >>> How-To-Repeat: >> Not applicable. >>> Fix: >> >> --- crontab Mon Jun 10 21:20:09 2002 >> +++ crontab.new Tue Nov 19 13:14:47 2002 >> @@ -19,6 +19,6 @@ >> 30 5 1 * * root periodic monthly >> # >> # time zone change adjustment for wall cmos clock, >> -# does nothing, if you have UTC cmos clock. >> +# does nothing if you have UTC cmos clock. >> # See adjkerntz(8) for details. >> 1,31 0-5 * * * root adjkerntz -a > > Something should be done about the first comma too. FWIW, the bug fixed by this commit is a Germanism. In German, subordinate clauses *must* be separated by a comma. That doesn't apply to the comma you're looking at. > crontab is apparently supposed to be written in non-English with all > "sentences" in comments not beginning with a capital letter and not > ending with a period, but the comment about adjkerntz violates this > by using bad English (a comma splice) in its first line, the stray > comma and a period in its second line, and actual English in its > last line. This is, as you say, a supposition. FWIW, comma splices are valid in German. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message