From owner-freebsd-ports@FreeBSD.ORG Tue Jan 24 19:43:58 2006 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB26216A41F for ; Tue, 24 Jan 2006 19:43:58 +0000 (GMT) (envelope-from bruno@clisp.org) Received: from ftp.ilog.fr (ftp.ilog.fr [81.80.162.195]) by mx1.FreeBSD.org (Postfix) with ESMTP id B912D43D49 for ; Tue, 24 Jan 2006 19:43:57 +0000 (GMT) (envelope-from bruno@clisp.org) Received: from laposte.ilog.fr (cerbere-qfe0 [81.80.162.193]) by ftp.ilog.fr (8.13.1/8.13.1) with ESMTP id k0OJhkRA011486; Tue, 24 Jan 2006 20:43:51 +0100 Received: from marbore.ilog.biz (marbore.ilog.biz [172.17.2.61]) by laposte.ilog.fr (8.13.1/8.13.1) with ESMTP id k0OJhdVN028835; Tue, 24 Jan 2006 20:43:39 +0100 Received: from honolulu.ilog.fr ([172.16.15.122]) by marbore.ilog.biz with Microsoft SMTPSVC(6.0.3790.1830); Tue, 24 Jan 2006 20:44:47 +0100 Received: from localhost (localhost [127.0.0.1]) by honolulu.ilog.fr (Postfix) with ESMTP id 7788D3BD8A; Tue, 24 Jan 2006 19:36:23 +0000 (UTC) From: Bruno Haible To: Paul Eggert , Dieter Date: Tue, 24 Jan 2006 20:36:22 +0100 User-Agent: KMail/1.5 References: <200601201744.RAA11472@sopwith.solgatos.com> <877j8qvzjs.fsf@penguin.cs.ucla.edu> In-Reply-To: <877j8qvzjs.fsf@penguin.cs.ucla.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200601242036.22247.bruno@clisp.org> X-OriginalArrivalTime: 24 Jan 2006 19:44:47.0424 (UTC) FILETIME=[A1D19400:01C6211E] Cc: bug-gnulib@gnu.org, bug-coreutils@gnu.org, bug-bison@gnu.org, freebsd-ports@freebsd.org Subject: Re: [bug-gnulib] Re: portability fix for bison-1.75 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2006 19:43:58 -0000 Paul Eggert wrote: > (__strndup): Revert to K&R-style function dfns, the glibc style. Huh? We know the problems of K&R-style function definitions: arguments of type 'float', 'short' and 'char' are implicitly promoted, leading to a clash with the function prototype. Empty argument lists allow calls later in the same compilation unit with argument, if no '(void)' protype was seen. - Wouldn't it be better to move the glibc source code to ANSI C? > * lib/strnlen.c: Don't claim it's taken from glibc; it's not. It was taken from glibc/string/strnlen.c in 2000 or 2001, but glibc has diverged since then, moving the file to glibc/sysdeps/generic/strnlen.c and now back to glibc/string/strnlen.c. How about this additional patch? *** modules/strnlen 9 Jan 2006 21:40:18 -0000 1.6 --- modules/strnlen 24 Jan 2006 19:42:27 -0000 *************** *** 20,24 **** LGPL Maintainer: ! glibc --- 20,24 ---- LGPL Maintainer: ! all *** config/srclist.txt 24 Jan 2006 14:06:47 -0000 1.113 --- config/srclist.txt 24 Jan 2006 19:42:27 -0000 *************** *** 259,265 **** #$LIBCSRC/string/strcasecmp.c lib gpl #$LIBCSRC/string/strchrnul.c lib gpl #$LIBCSRC/string/strerror.c lib gpl - #$LIBCSRC/string/strnlen.c lib gpl #$LIBCSRC/sysdeps/posix/gettimeofday.c lib gpl #$LIBCSRC/sysdeps/posix/rename.c lib gpl #$LIBCSRC/sysdeps/unix/mkdir.c lib gpl --- 259,264 ----