From owner-svn-src-head@FreeBSD.ORG Thu Nov 13 20:40:38 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DBE31065670; Thu, 13 Nov 2008 20:40:38 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4C37E8FC17; Thu, 13 Nov 2008 20:40:38 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id mADKecKb068336; Thu, 13 Nov 2008 20:40:38 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id mADKecHe068335; Thu, 13 Nov 2008 20:40:38 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <200811132040.mADKecHe068335@svn.freebsd.org> From: Ed Schouten Date: Thu, 13 Nov 2008 20:40:38 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r184938 - head/contrib/telnet/telnetd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2008 20:40:38 -0000 Author: ed Date: Thu Nov 13 20:40:38 2008 New Revision: 184938 URL: http://svn.freebsd.org/changeset/base/184938 Log: Use strlcpy() instead of strcpy(). Requested by: mlaier Modified: head/contrib/telnet/telnetd/sys_term.c Modified: head/contrib/telnet/telnetd/sys_term.c ============================================================================== --- head/contrib/telnet/telnetd/sys_term.c Thu Nov 13 19:57:33 2008 (r184937) +++ head/contrib/telnet/telnetd/sys_term.c Thu Nov 13 20:40:38 2008 (r184938) @@ -414,7 +414,8 @@ getpty(int *ptynum __unused) if (pn == NULL) return (-1); - strcpy(line, pn); + if (strlcpy(line, pn, sizeof line) >= sizeof line) + return (-1); return (p); }