From nobody Thu Feb 22 09:09:19 2024 X-Original-To: java@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TgS4w0HMjz5CDyH for ; Thu, 22 Feb 2024 09:09:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TgS4v1xsJz4YZH for ; Thu, 22 Feb 2024 09:09:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708592959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qHAXWDou7WMWLEZ8OtS0Nv5MI+Uj4KcC9zIkMrReNO4=; b=Q0Ui5/E/3ROyIZ7CWni3IOxxBkO5yFXj9wfj4BHlTvrlx4ysU+1HMXjFY7IfQmtBX5PFj3 emUtJjn4FUV0m4paMwB5IoH17hWxecga42ZtwLxaqEOajRI96wWtkgNLQwJT4ibvqsAWsU liiXJSA8pfOQ2kMgiTIwx4M07c9x2MOsCvpEONio0PpX95Kg9TT82Fbsi1sUTKPfybVP74 yQfWh4kByaxN0COYbVsg2LAxeoUHnJsDIY8e/FwDwyA2Kz+DIhrqGB+BL8+BoFPetkJ+FL +/kahBvzuaSkxfgU+SdwYr1w29IQOxyz9TPvtBrltIVylcd1T141/y/eHiFb2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708592959; a=rsa-sha256; cv=none; b=od4BISa270/FgjDEkpjKQaJDCIfT+EvbW9v2NSTT38zjVfXgdbYVrGnkX3CBKbdJjbemtx anEN0Uvo7UTz7oWcIN+Zf5HzOIQaCoSTvRr+ZWMyghu7766oi+VhhvnI9QN+hBGpP8tdO2 Q+e2uEJadpVOLubrHmVk7c47Pt2Z66waeHmAF8gx9Br4WgfQhSP5Kkn17j/QCMPOeA+GLg KVFLKfRs8UYbdshFRVP7IoE4Lc18jm5e1Uv3kuuq2GGA4mtD5x12cRIBpy8M7jWUM/YaJF b4ZOcA2iiLsQn4adZ2aJYpDtAs9k/4AFrYuaQNSZr/LmPyJIb3Dgy3fM5lipGQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TgS4v10VHzQ6p for ; Thu, 22 Feb 2024 09:09:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41M99JPu090536 for ; Thu, 22 Feb 2024 09:09:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41M99JPE090535 for java@FreeBSD.org; Thu, 22 Feb 2024 09:09:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: java@FreeBSD.org Subject: [Bug 277204] *: ports misusing WITH_CCACHE_BUILD and NO_CCACHE Date: Thu, 22 Feb 2024 09:09:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: nimaje+fbz@bureaucracy.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Porting Java to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-java List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-java@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277204 --- Comment #4 from Benjamin Takacs --- (In reply to Gleb Popov from comment #2) As features are still loaded in the post section of bsd.port.mk, I don't see how it would help these ports to detect if ccache support is enabled. By allowing them to read WITH_CCACHE and making only setting WITH_CCACHE with= out setting CCACHE_DIR a hard error instead of a warning? And if I read bsd.por= t.mk right there still could be cases when WITH_CCACHE and WITHOUT_CCACHE are se= t, when the user sets WITH_CCACHE=3Dyes WITHOUT_CCACHE_PORTS=3D"someport". So = ports wanting to detect if ccache is enabled would have to use .if defined(WITH_CCACHE) && !defined(WITHOUT_CCACHE) after WITH{,OUT}_ and WITH__PORTS is processed in the options section. Additionally bsd.ccache.mk reads the undocumented variable NOCCACHE (and se= ts NO_CCACHE=3Dt if it was set); still sets CCACHE_ENABLED=3Dyes if WITH_CCACH= E_BUILD and NO_CCACHE are set (but no port that disables ccache via NO_CCACHE should try to detect ccache support, so that's just a minor correctness issue); se= ts NO_CCACHE in some cases. --=20 You are receiving this mail because: You are on the CC list for the bug.=