From owner-cvs-src@FreeBSD.ORG  Thu Feb 12 13:57:56 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 931)
	id C258016A4CF; Thu, 12 Feb 2004 13:57:56 -0800 (PST)
Date: Thu, 12 Feb 2004 15:57:56 -0600
From: juli mallett <jmallett@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Message-ID: <20040212215756.GA69683@FreeBSD.org>
References: <200402120411.i1C4Bf8U036349@repoman.freebsd.org>
	<xzpznbodbo6.fsf@dwp.des.no> <20040212075852.GA93983@FreeBSD.org>
	<20040213053949.D24403@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20040213053949.D24403@gamplex.bde.org>
User-Agent: Mutt/1.4.1i
X-Negacore: Yes
X-Authentication-Warning: localhost: juli pwned teh intarweb
cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>
cc: Tim Kientzle <kientzle@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/lib/libarchive Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2004 21:57:56 -0000

* Bruce Evans <bde@zeta.org.au> [ Date: 2004-02-12 ]
	[ w.r.t. Re: cvs commit: src/lib/libarchive Makefile ]
> On Thu, 12 Feb 2004, juli mallett wrote:
> 
> > * Dag-Erling Smørgrav <des@des.no> [ Date: 2004-02-12 ]
> > 	[ w.r.t. Re: cvs commit: src/lib/libarchive Makefile ]
> > > Tim Kientzle <kientzle@FreeBSD.org> writes:
> > > >   Log:
> > > >   libarchive itself is now completely clean at WARNS=10 on all architectures.
> > > >
> > > >   Unfortunately, the stock zlib.h is not:
> > > >     line 885: 'err' parameter shadows global 'err' definition from <err.h>
> > >
> > > This is trivial to fix, if we're willing to take zlib.h off the vendor
> > > branch or manage to convince Gailly to take our patch.
> >
> > Personally, I'm against prototype declarations in headers being
> > warning checked for parameter names, even moreso for headers not
> > included within the headers in question.
> 
> We force checking of system (including standard) headers using
> -Wsystem-headers, and I think this checking applies here.  I wouldn't
> want to turn of checking for all warnings in system headers.
> 
> Anyway, names like "err" in system headers are just bugs.  They break
> application code like:
> 
> #define	err	if you can see this, then <zlib.h> is broken
> #include <zlib.h>
> 
> zlib.h has many such bugs.  It looks like an application header that
> escaped to become a system header.

I think this particular form of warning is bogus.  In definitions,
argument names matter warnings-wise, in declarations, they don't.
Yes it's in the wrong namespace, but there's other problems you can
run into.
-- 
juli mallett. email: jmallett@freebsd.org; efnet: juli;
o/~ sweet talk like candy rots teeth o/~