From nobody Mon Jun 22 21:45:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gkhZL0tt6z6j6LR for ; Mon, 22 Jun 2026 21:45:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gkhZK5S1Qz3PyC for ; Mon, 22 Jun 2026 21:45:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782164713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2OI1P6rLGUppO0UugYLbCSWKd+s3xbld59M97polUws=; b=aDsvIbNo4UnUUbI8ZjJ3mjYy+mJHqkuXsOU8Wniv5cRYDh4mop2Wts+fBEOi8RXRQh+Dkl PTI3UMr3YDy/LpE/sBkw4fuuJXhLKYkVsp4vMFXaEBIn+zSBQxE9sjdqpEK7QObnt/dFG/ k1XFGVx36ysnYuW2n+F4oWEF+/zwULPVoDWYTIqE6K22DEL4Iz8BSs2MEDuNbNjehVGxuS 1B96zBw3ghH57akLB3DQT5muErbSEDxwBxQpBG+xFZdFYqC5LI7/eEj7pMbse4xUM9/Xpy e7DWDbMi1EGBkMECLGSlPniToYR9RppR07PZtu2KrsPXeNfZNKBvGVADPBeHgA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782164713; a=rsa-sha256; cv=none; b=NxVVgJ8mGYSNxc0queX1y1tty/uURgLMIdLg4Hn1S1aPZzcS1d1ATznH55YLMW29R9kGi0 35vwSPoA4E2BdcZg5CeTRSmz4uwT3Df40DhLPbs5Spx5tM9ltjQV3LyeVd1pdoGFZOKoSV 2Tdos40rq2fyACd6XNKeTWAm+EpJRYh/viIw3pzlF6nThHkobHRKSiM3EO6IHxIvSNBCYq S6H9XBAiPQTHs+MxeaZV0L584bmMow3PnFoe2w0yaLBODjh9xc5RRNjQK5nd/GqrltBxJM pumyeKTQ1TnNV8k1WTr/tWkcol4a9jNY/3ipCJJ+4dcEss7cMV1oEizb5osA9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782164713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2OI1P6rLGUppO0UugYLbCSWKd+s3xbld59M97polUws=; b=m+wJTEUdM81V39CQ/oidbemdgcsztigSLxn95winhsQqIef3mr8saW9+iKAaz7S8TJ73XF WpZGIfaoyIj8ImdFjdR/r46M2GZmp6iJCi28bwnqUiLj+P7X8Y7jblPEOr0xEbDJc+6rEq 4+i18gwwGTFPuhsgwiKH+GF6d/0awK9F1ocQPRz9/ibmT3E7Pw5Dsz1tQSWtPeW/ylkC3A 3rMc54AUAmct5I5Dj7rtJk17Fhk9n9gmS9Ux6HiKPVbi76g1hNccreXr3N+4l+oiLckipz tIi5xPrJ5tkAvr+zcVqfv1Qq55TMb4bryINL8h3MMbYdBjrWf2bQ/RUTtS0s7g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gkhZK444Zz14pZ for ; Mon, 22 Jun 2026 21:45:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1fbcd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 22 Jun 2026 21:45:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Jane Smith From: Mark Johnston Subject: git: 635ad6f2ec97 - main - librpcsec_gss: Fix an off-by-one in rpc_gss_get_principal_name() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 635ad6f2ec97e9c6b1f15620cd5ee84eb632082f Auto-Submitted: auto-generated Date: Mon, 22 Jun 2026 21:45:08 +0000 Message-Id: <6a39ace4.1fbcd.1e573503@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=635ad6f2ec97e9c6b1f15620cd5ee84eb632082f commit 635ad6f2ec97e9c6b1f15620cd5ee84eb632082f Author: Jane Smith AuthorDate: 2026-06-22 21:40:53 +0000 Commit: Mark Johnston CommitDate: 2026-06-22 21:44:44 +0000 librpcsec_gss: Fix an off-by-one in rpc_gss_get_principal_name() Include an extra byte for the nul-terminator, otherwise we may end up with an out-of-bounds write. The corresponding bug in the kernel implementation was fixed by commit e3081f7e3e2d ("kgssapi(4): Fix string overrun in Kerberos principal construction"). Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D57738 --- lib/librpcsec_gss/svc_rpcsec_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librpcsec_gss/svc_rpcsec_gss.c b/lib/librpcsec_gss/svc_rpcsec_gss.c index 73b92371e6d0..a15542330697 100644 --- a/lib/librpcsec_gss/svc_rpcsec_gss.c +++ b/lib/librpcsec_gss/svc_rpcsec_gss.c @@ -247,7 +247,7 @@ rpc_gss_get_principal_name(rpc_gss_principal_t *principal, * Construct a gss_buffer containing the full name formatted * as "name/node@domain" where node and domain are optional. */ - namelen = strlen(name); + namelen = strlen(name) + 1; if (node) { namelen += strlen(node) + 1; }