From owner-cvs-all Wed Feb 21 4:15:56 2001 Delivered-To: cvs-all@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.189]) by hub.freebsd.org (Postfix) with SMTP id 72DB637B491 for ; Wed, 21 Feb 2001 04:15:37 -0800 (PST) (envelope-from roam@orbitel.bg) Received: (qmail 99818 invoked by uid 1000); 21 Feb 2001 12:13:42 -0000 Date: Wed, 21 Feb 2001 14:13:42 +0200 From: Peter Pentchev To: Ben Smithurst Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <20010221141342.A98551@ringworld.oblivion.bg> Mail-Followup-To: Ben Smithurst , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200102211210.f1LCAKN41997@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200102211210.f1LCAKN41997@freefall.freebsd.org>; from ben@FreeBSD.org on Wed, Feb 21, 2001 at 04:10:19AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Feb 21, 2001 at 04:10:19AM -0800, Ben Smithurst wrote: > ben 2001/02/21 04:10:19 PST > > Modified files: > share/man/man9 style.9 > Log: > Don't suggest > > if (error = function(a1, a2)) > > since it causes a warning with -Wall. Change it so it has an explicit test > against zero, > > if ((error = function(a1, a2)) != 0) I've sometimes seen tests like: if (error = function(a1, a2), error != 0) Is this not a bit clearer? G'luck, Peter -- I am the thought you are now thinking. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message