From owner-freebsd-bugs@FreeBSD.ORG Mon Apr 30 02:00:19 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3C83716A402 for ; Mon, 30 Apr 2007 02:00:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 1E42813C44B for ; Mon, 30 Apr 2007 02:00:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l3U20IGE071387 for ; Mon, 30 Apr 2007 02:00:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l3U20IJe071386; Mon, 30 Apr 2007 02:00:18 GMT (envelope-from gnats) Date: Mon, 30 Apr 2007 02:00:18 GMT Message-Id: <200704300200.l3U20IJe071386@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Ganbold Cc: Subject: Re: kern/112119: system hangs when starts k3b on RELENG_6 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ganbold List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 02:00:19 -0000 The following reply was made to PR kern/112119; it has been noted by GNATS. From: Ganbold To: Thomas Quinot Cc: Scott Long , Nikolay Pavlov , freebsd-stable@FreeBSD.ORG, mjacob@FreeBSD.ORG, linimon@FreeBSD.ORG, bug-followup@FreeBSD.ORG Subject: Re: kern/112119: system hangs when starts k3b on RELENG_6 Date: Mon, 30 Apr 2007 09:50:48 +0800 This is a multi-part message in MIME format. --------------080102070607070608080708 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Thomas Quinot wrote: > * Scott Long, 2007-04-27 : > > >> Oh hell, I know exactly what the problem is! The opcode for a >> TEST_UNIT_READY is 0x00. This is probably the command that is >> generating the CHECK_CONDITION. The test for saved_cmd is entirely >> bogus. >> > > Hmmmm. Looks like a very plausible culprit. Good catch Scott! > (I felt there had to be something wrong when I wrote that test, > incidentally, precisely because of TEST_UNIT_READY). > > Nikolay, Ganbold, (and others), here's another patch against 1.42.2.3, > please let me know if it works for you. > > Thomas. > > Index: atapi-cam.c > =================================================================== > RCS file: /space/mirror/ncvs/src/sys/dev/ata/atapi-cam.c,v > retrieving revision 1.50 > diff -u -r1.50 atapi-cam.c > --- atapi-cam.c 14 Mar 2007 01:59:00 -0000 1.50 > +++ atapi-cam.c 27 Apr 2007 19:26:09 -0000 > @@ -729,7 +743,7 @@ > * issued a REQUEST SENSE automatically and that operation > * returned without error. > */ > - if (request->u.atapi.saved_cmd != 0 && request->error == 0) { > + if (request->u.atapi.sense.key != 0 && request->error == 0) { > bcopy (&request->u.atapi.sense, &csio->sense_data, sizeof(struct atapi_sense)); > csio->ccb_h.status |= CAM_AUTOSNS_VALID; > } > > > > Scott, Thomas, thank you very much for the effort fixing this problem. k3b starts fine with this patch. Ganbold --------------080102070607070608080708 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Thomas Quinot wrote: 
* Scott Long, 2007-04-27 :
 
   
Oh hell, I know exactly what the problem is!  The opcode for a
 TEST_UNIT_READY is 0x00.  This is probably the command that is
 generating the CHECK_CONDITION.  The test for saved_cmd is entirely
 bogus.
     

 Hmmmm. Looks like a very plausible culprit. Good catch Scott!
 (I felt there had to be something wrong when I wrote that test,
 incidentally, precisely because of TEST_UNIT_READY).
 
 Nikolay, Ganbold, (and others), here's another patch against 1.42.2.3,
 please let me know if it works for you.
 
 Thomas.
 
 Index: atapi-cam.c
 ===================================================================
 RCS file: /space/mirror/ncvs/src/sys/dev/ata/atapi-cam.c,v
 retrieving revision 1.50
 diff -u -r1.50 atapi-cam.c
 --- atapi-cam.c	14 Mar 2007 01:59:00 -0000	1.50
 +++ atapi-cam.c	27 Apr 2007 19:26:09 -0000
 @@ -729,7 +743,7 @@
  		 * issued a REQUEST SENSE automatically and that operation
  		 * returned without error.
  		 */
 -		if (request->u.atapi.saved_cmd != 0 && request->error == 0) {
 +		if (request->u.atapi.sense.key != 0 && request->error == 0) {
  		    bcopy (&request->u.atapi.sense, &csio->sense_data, sizeof(struct atapi_sense));
  		    csio->ccb_h.status |= CAM_AUTOSNS_VALID;
  		}

Scott, Thomas, thank you very much for the effort fixing this problem.
k3b starts fine with this patch.

Ganbold


--------------080102070607070608080708--