From owner-cvs-all Thu May 6 23:19:34 1999 Delivered-To: cvs-all@freebsd.org Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (Postfix) with ESMTP id C0F0D14E23; Thu, 6 May 1999 23:19:25 -0700 (PDT) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id PAA28489; Fri, 7 May 1999 15:49:23 +0930 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id PAA18873; Fri, 7 May 1999 15:49:22 +0930 (CST) Date: Fri, 7 May 1999 15:49:21 +0930 From: Greg Lehey To: Bruce Evans , Poul-Henning Kamp Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/sys disk.h Message-ID: <19990507154920.L40359@freebie.lemis.com> References: <199905070611.QAA13928@godzilla.zeta.org.au> <199905070559.PAA12395@godzilla.zeta.org.au> <7862.926057236@critter.freebsd.dk> <199905070559.PAA12395@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: <199905070559.PAA12395@godzilla.zeta.org.au>; from Bruce Evans on Fri, May 07, 1999 at 03:59:09PM +1000 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Friday, 7 May 1999 at 16:11:56 +1000, Bruce Evans wrote: >>> sys/disk.h was intentionally not removed, since it has some historical >>> interest and probably should eventually contain half of the declarations >>> that are now in sys/disklabel.h. You just weren't supposed to use it. >> >> Best way to make sure people don't is to remove it. > > #error "you are not meant to use this" Funny, I thought the documentation went into /usr/src/share/doc, and old, no longer used files went to Attic. What am I missing? People with any kind of memory will recall that I don't always agree with phk, but I think he's 100% right here (and in some other tidying up stuff he's doing). There's a place for historical files, but it's not today's -CURRENT source tree. The only thing that will happen if the cruft is left in -CURRENT is that people like me will use the stuff. An #error in the file would just confuse the issue. As phk has pointed out, struct buf contains a whole lot of fields which never got used, but which countless generations of driver programmers religiously initialized. Cleaning this stuff up is good. Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message