From owner-freebsd-current Wed May 29 13:38: 0 2002 Delivered-To: freebsd-current@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 4E0B237B405; Wed, 29 May 2002 13:37:55 -0700 (PDT) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.3/8.12.2) with ESMTP id g4TKblJn009988; Wed, 29 May 2002 13:37:47 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.3/8.12.3/Submit) id g4TKbl6Y009987; Wed, 29 May 2002 13:37:47 -0700 (PDT) Date: Wed, 29 May 2002 13:37:47 -0700 From: "David O'Brien" To: Matthew Dillon Cc: Julian Elischer , John Baldwin , FreeBSD current users Subject: Re: Seeking OK to commit KSE MIII Message-ID: <20020529133747.B683@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG Mail-Followup-To: David O'Brien , Matthew Dillon , Julian Elischer , John Baldwin , FreeBSD current users References: <20020529124434.A2156@dragon.nuxi.com> <200205292007.g4TK71YD062671@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200205292007.g4TK71YD062671@apollo.backplane.com>; from dillon@apollo.backplane.com on Wed, May 29, 2002 at 01:07:01PM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, May 29, 2002 at 01:07:01PM -0700, Matthew Dillon wrote: > :On Wed, May 29, 2002 at 11:26:26AM -0700, Julian Elischer wrote: > :> > > :> > 9) More gratuitous braces as well as gratuituos ()'s and white space > :> > changes in ithread_schedule() obfuscate the functional diffs. > :> > :> I guess so though it made it a hell of a lot more readable to me. > : > :That isn't the issue. You have posted a diff that you plan to commit in > :an implied one-shot event. If you really have(want) to make these style > :changes, please commit them, and them alone right now. That will remove > :them from this patch and make jhb an Co'.s life easier. > > No hold on a minute. Some of us believe that adding those extra > braces and parenthesis makes the code a whole lot more readable. they > are NOT gratuitous in the least, certainly not from my point of view! Uh... Matt where did I say they were. I requested that they be committed separately from functionality. And if they were going to be committed, for it to happen now. That is all I said -- nothing more. I held me tongue on the "gratuitous" issue and the fact that Julian has a long history of breaking existing style in his commits. > Furthermore, it is an extreme and inappropriate imposition on Julian > to require that he extract all the alleged 'gratuitous braces and > ()'s)' into a separate commit. Uh, no it isn't. That is the rules we operate under. This type of request comes up _daily_, and is generally agreed upon by most committers. Sorry, but the work involved is just part of making commits. > I will say quite bluntly that in the vast majority of cases on these > lists where I've seen someone ask for whitespace fixes to be committed > separately, I have yet to see any significant (or any at all!) developers > take advantage of the separate commits when incorporating the work into > their own development trees. I personally do look at diffs using -r -r followed by -r -r Should I start sending an email to -current every time I do so that you will know that someone does? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message