From owner-cvs-src@FreeBSD.ORG  Thu Dec 29 20:53:04 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5C50416A41F;
	Thu, 29 Dec 2005 20:53:04 +0000 (GMT) (envelope-from jhb@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 00CED43D7C;
	Thu, 29 Dec 2005 20:53:01 +0000 (GMT) (envelope-from jhb@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jBTKr1HX082723;
	Thu, 29 Dec 2005 20:53:01 GMT (envelope-from jhb@repoman.freebsd.org)
Received: (from jhb@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jBTKr1Br082722;
	Thu, 29 Dec 2005 20:53:01 GMT (envelope-from jhb)
Message-Id: <200512292053.jBTKr1Br082722@repoman.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Date: Thu, 29 Dec 2005 20:53:01 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/kern subr_witness.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Dec 2005 20:53:04 -0000

jhb         2005-12-29 20:53:01 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             subr_witness.c 
  Log:
  Fix a deadlock I introduced with the recently added printf to warn about
  spin locks that are not in the static order list.  It is not safe to call
  printf while holding the witness spin mutex since the console drivers that
  back printf may need to use their own spin locks which would try to talk
  to witness when they were locked.  Given this, it is possible for one
  CPU to lock a console driver lock (such as sio) which then tries to lock
  the witness lock while another CPU is doing the printf while holding the
  witness lock.  Fix this by moving the printf outside of the witness lock.
  All other printf's in witness are already correct.
  
  MFC after:      3 days
  
  Revision  Changes    Path
  1.208     +14 -12    src/sys/kern/subr_witness.c