From owner-freebsd-arch@freebsd.org Tue Feb 16 17:20:36 2016 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B416AAAA51E for ; Tue, 16 Feb 2016 17:20:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 969C2159A for ; Tue, 16 Feb 2016 17:20:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 86BFFB9BA; Tue, 16 Feb 2016 12:20:35 -0500 (EST) From: John Baldwin To: Jilles Tjoelker Cc: freebsd-arch@freebsd.org Subject: Re: Refactoring asynchronous I/O Date: Mon, 15 Feb 2016 17:10:19 -0800 Message-ID: <18990810.Gs6uxxBMa9@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <20160211223238.GA73182@stack.nl> References: <2793494.0Z1kBV82mT@ralph.baldwin.cx> <2604669.yblYTI1T32@ralph.baldwin.cx> <20160211223238.GA73182@stack.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 16 Feb 2016 12:20:35 -0500 (EST) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 17:20:36 -0000 On Thursday, February 11, 2016 11:32:38 PM Jilles Tjoelker wrote: > On Wed, Feb 10, 2016 at 04:21:30PM -0800, John Baldwin wrote: > > I've pushed a new version with a vfs.aio.enable_unsafe sysctl > > (defaults to off). If you think this is ok then I'll work on cleaning > > up some of the module bits (removing the unload support mostly). I > > figure marking the syscalls as STD and removing all the helper stuff > > can be done as a followup commit to reduce extra noise in this diff > > (which is large enough on its own). > > > https://github.com/freebsd/freebsd/compare/master...bsdjhb:aio_rework > > > (Also, for the inital commit I will leave out the socket protocol > > hook. That can be added later.) > > Looks good to me, except that the error should be [ENOTSUP] instead of > the overloaded [EINVAL]. Ok. I've done some further cleanups and posted a commit candidate at https://reviews.freebsd.org/D5289 for anyone else who is interested. -- John Baldwin