Date: Tue, 26 Mar 2013 12:59:27 +0100 From: Florent Peterschmitt <florent@peterschmitt.fr> To: freebsd-ports@freebsd.org Subject: Re: Ports should provide knobs disabling unwanted network services Message-ID: <51518D9F.6040707@peterschmitt.fr> In-Reply-To: <20130326090019.GB6037@straylight.m.ringlet.net> References: <1364123355503-5798581.post@n5.nabble.com> <514EF84F.1090208@peterschmitt.fr> <1364126459718-5798594.post@n5.nabble.com> <CACdU%2Bf8FcqTQk=672S4qYjCgH0tVtgBg5YZPk8tCKzng=gjhbA@mail.gmail.com> <514FC573.8060806@peterschmitt.fr> <CACdU%2Bf9vjkB%2B2=ce7wPoAbbnAwy9YU7SNWnwcCmvtwSVTUci1g@mail.gmail.com> <515158B2.2080900@peterschmitt.fr> <20130326090019.GB6037@straylight.m.ringlet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2ROTUMBJFBFMBMWKNENVW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Le 26/03/2013 10:00, Peter Pentchev a =C3=A9crit : > On Tue, Mar 26, 2013 at 09:13:38AM +0100, Florent Peterschmitt wrote: >> Le 25/03/2013 04:40, Scot Hetzel a =C3=A9crit : >>> On Sun, Mar 24, 2013 at 10:33 PM, Florent Peterschmitt >>> <florent@peterschmitt.fr> wrote: >>>> Le 24/03/2013 17:34, Scot Hetzel a =C3=A9crit : >>>>> On Sun, Mar 24, 2013 at 7:00 AM, Beeblebrox <zaphod@berentweb.com> = wrote: >>>>>> I would be very happy to submit a patch, if I actually knew how to= write >>>>>> one... >>>>>> >>>>> >>>>> It is quite simple to create the patch. >>>>> >>>>> If you have a working copy checked out with svn, then it would be: >>>>> >>>>> cd /usr/ports/[category]/[port] >>>>> - Make the necessary changes to the port >>>>> - After testing the port make sure to do a 'make clean' >>>>> svn diff > port.diff >>>>> >>>>> Otherwise make a copy of the port: >>>>> >>>>> cd /usr/ports/[catagory] >>>>> cp port port-orig >>>>> cd port >>>>> - Make the necessary changes to port >>>>> - After testing port make sure to do a 'make clean' >>>>> cd .. >>>>> diff -ruN port-orig port > port.diff >>>>> >>>>> Then just submit the port.diff in a PR using either send-pr or >>>>> http://www.freebsd.org/send-pr.html. >>>>> >>>> >>>> Is there a way to manually make a patch that will say : >>>> >>>> --- MyFile >>>> +++ MyFile >>>> >>>> Even if these files are in two distinct trees ? >>>> >>> There is always a way to do that: >>> >>> diff -u /path/to/original/port/MyFile /path/to/modified/port/MyFile >= >>> /place/to/save/patch/port.diff >>> >>> or if you modifed several files: >>> >>> diff -ruN /path/to/original/port /path/to/modified/port > >>> /place/to/save/patch/port.diff >>> >> Hum yes but what I mean is that we'll have, for example: >> >> --- /home/florent-gentoo/patch/old/one 2013-03-24 14:04:20.757200724 += 0100 >> +++ /home/florent-gentoo/patch/new/one 2013-03-24 14:04:08.541201548 += 0100 >> [=E2=80=A6] >> >> And what I want is: >> >> --- /home/florent-gentoo/patch/old/one 2013-03-24 14:04:20.757200724 += 0100 >> +++ /home/florent-gentoo/patch/old/one 2013-03-24 14:04:08.541201548 += 0100 >> [=E2=80=A6] >> >> SCM make patches like the second one and I'm no sure it is possible to= >> do without modifying by hand the patch generated. >=20 > Well, one way to do it would be to actually *use* an SCM :) My > preferred way would be a Git copy of the Subversion repository - then > you do your changes in your local Git tree and periodically pull down > the changes from the FreeBSD Subversion repo and merge them into yours.= >=20 > But really, is there actually a reason why you don't want two separate > directories? To be honest, before the advent of Subversion and Git > everyone did their patches that way (well, there *were* local CVS > repositories and checkouts from there, but most of the patches were > diffs between two side-by-side directories) - and I don't think anyone > ever complained. Are there any problems you are seeing with two paths > in the diff headers, or is it just aesthetic? >=20 > G'luck, > Peter >=20 Hum. I'm definitively misunderstanding patching process and I just discovered that even if the header is not with the two same subdirs, it works anyway. For the moment I've no time for porting but I'll study it as soon as possible :) Thanks ;) --=20 Florent Peterschmitt +33 (0)6 64 33 97 92 florent@peterschmitt.fr ------enig2ROTUMBJFBFMBMWKNENVW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRUY2kAAoJEMtO2Sol0IIm0E8H/1rfw1gGNy4fp4ziKZLJAqby curFvWo1QrobXTK7IqMvlC18TnsR1nII/1/QDSFUEPK1aSVsfW0UlvO9ItE8Cwsx Y3Tv725MtFmRWQtfi2xNhQILcdmJrBMYmYbbZoEVbP25iwnfn35M2f2fwkxLzUbn 144AOkQs98FssCuQnzXfmycPe3Fhw8cEDj4wNLNWvuoHDXV5VWrIwYiNgU7CWTiX 1wlcB8QABQbFG5lYop1aGkXCuXVvWfRTa9F6MYujephrq9SJhaKrSaljhptwlq+P gd3lL6Oy/mlAEEA/z5doWHWNNiVBtsMjWe3+v+RCi1wcMqZKMEYBnqI0qGfJTGU= =5Nfx -----END PGP SIGNATURE----- ------enig2ROTUMBJFBFMBMWKNENVW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51518D9F.6040707>