From owner-cvs-all Thu Apr 23 05:40:50 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA24525 for cvs-all-outgoing; Thu, 23 Apr 1998 05:40:50 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from hda.hda.com (hda-bicnet.bicnet.net [208.220.66.37]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA24518 for ; Thu, 23 Apr 1998 05:40:46 -0700 (PDT) (envelope-from dufault@hda.hda.com) Received: (from dufault@localhost) by hda.hda.com (8.8.5/8.8.5) id IAA23320; Thu, 23 Apr 1998 08:36:34 -0400 (EDT) From: Peter Dufault Message-Id: <199804231236.IAA23320@hda.hda.com> Subject: Re: cvs commit: src/sys/sys time.h In-Reply-To: <19980423130550.30970@follo.net> from Eivind Eklund at "Apr 23, 98 01:05:50 pm" To: eivind@yes.no (Eivind Eklund) Date: Thu, 23 Apr 1998 08:36:32 -0400 (EDT) Cc: cvs-committers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL25 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > On Thu, Apr 23, 1998 at 01:36:19PM +1000, Bruce Evans wrote: > > >eivind 1998/04/22 17:11:32 PDT > > > > > > Modified files: > > > sys/sys time.h > > > Log: > > > Wrap timerclear in do { ... } while(0) > > > > Wrong fix. The do-while(0) hack is bogus for macros that expand to an > > expression. > > I strongly disagree. Such macros should most definately have > do { ... } while(0) protection, to avoid people depending on the fact > that they just happen to be expressions. Otherwise, we're inviting > people to depend on implementation details. Given no specification for timerclear pre-existing behavior should be maintained. Given a specification that says it behaves as if it returns void you're right. Peter -- Peter Dufault (dufault@hda.com) Realtime development, Machine control, HD Associates, Inc. Safety critical systems, Agency approval To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message