From owner-svn-src-all@FreeBSD.ORG Sun Nov 6 19:02:38 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E59C710659E3; Sun, 6 Nov 2011 19:02:38 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 33C428FC30; Sun, 6 Nov 2011 19:02:38 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id pA6J2cZ4037171; Sun, 6 Nov 2011 19:02:38 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id pA6J2cmj037169; Sun, 6 Nov 2011 19:02:38 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <201111061902.pA6J2cmj037169@svn.freebsd.org> From: Ed Schouten Date: Sun, 6 Nov 2011 19:02:38 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r227259 - head/usr.sbin/rmt X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Nov 2011 19:02:39 -0000 Author: ed Date: Sun Nov 6 19:02:37 2011 New Revision: 227259 URL: http://svn.freebsd.org/changeset/base/227259 Log: Mark global functions and/or variables in rmt(8) static where possible. This allows compilers and static analyzers to do more thorough analysis. Modified: head/usr.sbin/rmt/rmt.c Modified: head/usr.sbin/rmt/rmt.c ============================================================================== --- head/usr.sbin/rmt/rmt.c Sun Nov 6 19:02:31 2011 (r227258) +++ head/usr.sbin/rmt/rmt.c Sun Nov 6 19:02:37 2011 (r227259) @@ -54,25 +54,25 @@ __FBSDID("$FreeBSD$"); #include #include -int tape = -1; +static int tape = -1; -char *record; -int maxrecsize = -1; +static char *record; +static int maxrecsize = -1; #define SSIZE 64 -char device[SSIZE]; -char count[SSIZE], mode[SSIZE], pos[SSIZE], op[SSIZE]; +static char device[SSIZE]; +static char count[SSIZE], mode[SSIZE], pos[SSIZE], op[SSIZE]; -char resp[BUFSIZ]; +static char resp[BUFSIZ]; -FILE *debug; +static FILE *debug; #define DEBUG(f) if (debug) fprintf(debug, f) #define DEBUG1(f,a) if (debug) fprintf(debug, f, a) #define DEBUG2(f,a1,a2) if (debug) fprintf(debug, f, a1, a2) -char *checkbuf(char *, int); -void error(int); -void getstring(char *); +static char *checkbuf(char *, int); +static void error(int); +static void getstring(char *); int main(int argc, char **argv) @@ -220,7 +220,7 @@ getstring(char *bp) cp[i] = '\0'; } -char * +static char * checkbuf(char *rec, int size) { @@ -240,7 +240,7 @@ checkbuf(char *rec, int size) return (rec); } -void +static void error(int num) {