From owner-freebsd-ports@FreeBSD.ORG Sat Dec 17 18:55:19 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C9EF106566C; Sat, 17 Dec 2011 18:55:19 +0000 (UTC) (envelope-from jbeich@tormail.net) Received: from server2.hudsonvalleyhost.com (server2.hudsonvalleyhost.com [66.7.195.77]) by mx1.freebsd.org (Postfix) with ESMTP id 11F998FC0C; Sat, 17 Dec 2011 18:55:18 +0000 (UTC) Received: from rainbowwarrior.torservers.net ([77.247.181.164]:42553 helo=internal.tormail.net) by server2.hudsonvalleyhost.com with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.69) (envelope-from ) id 1RbzPh-001fP6-4H; Sat, 17 Dec 2011 13:55:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tormail.net; s=tm; h=Message-Id:X-TorMail-User:Content-Type:MIME-Version:Date:References:In-Reply-To:Subject:Cc:To:From; bh=v4mW2MagEVUWPxdEBSLvBeoc8W1DSP9Od2ZCrKITwik=; b=Rk0UL5SRyADibJxCq4kng6CrRsISwzw0AB70ZC+BDfQ7NMRikkQjrDf/dCSR+gDbr3GG17b8XZGy0Ys22wgP23O1VSHrP3CxKQ7OLq4TSA3CNUb/I4CW19uUWk0Hi8caelSLtdqYtFLW3n6bKi3OmfzJdxGS8mtgs5YQMZId4l0=; Received: from jbeich by internal.tormail.net with local (Exim 4.63) (envelope-from ) id 1RbzOV-000AQU-65; Sat, 17 Dec 2011 18:54:05 +0000 From: Jan Beich To: Chris Rees In-Reply-To: (Chris Rees's message of "Sat, 17 Dec 2011 16:47:35 +0000") References: <1RbxBi-0008Ls-5O@internal.tormail.net> Date: Sun, 18 Dec 2011 02:53:32 +0800 MIME-Version: 1.0 Content-Type: text/plain X-TorMail-User: jbeich Message-Id: <1RbzOV-000AQU-65@internal.tormail.net> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server2.hudsonvalleyhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tormail.net X-Source: X-Source-Args: X-Source-Dir: Cc: Christer Solskogen , freebsd-ports , garga@freebsd.org Subject: Re: Removal of use_gmake breaks lua X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 18:55:19 -0000 Chris Rees writes: >> Chris Rees writes: >> >>>> as seen here: >>>> http://docs.freebsd.org/cgi/getmsg.cgi?fetch=295602+0+/usr/local/www/db/text/2011/cvs-all/20111113.cvs-all >>> >>> I don't like the proposed solution; it's less hackish to just use >>> gmake again; most people have it installed anyway.... >> >> A non-hackish solution would involve fixing sys.mk to guard against >> recursive inclusion of __MAKE_CONF. bsd.port.mk is known to have >> this when using make(1) for do-build. >> >> Not that I mind shoving the issue under the carpet by using gmake. [...] > > Ah now there is a better solution :) It breaks non ports builds if the guard is propagated via .MAKEFLAGS. And one no longer can .if/.ifdef (in make.conf) innards of ports. > > I'll see if we can get it in the tree. Nevermind, in case of lang/lua 1/ sys.mk sets CFLAGS= from make.conf 2/ Makefile adds -fPIC to CFLAGS 3/ bsd.port.mk copies CFLAGS to MAKE_ENV 4/ sys.mk sets CFLAGS from make.conf again, `=' overrides CFLAGS from environment A simple make(1) build doesn't export CFLAGS # Makefile all: @cd foo && $(MAKE) @cd foo && CFLAGS='$(CFLAGS)' $(MAKE) # foo/Makefile all: @echo $(CFLAGS)