From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 15 18:30:03 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 475D216A4CE for ; Tue, 15 Mar 2005 18:30:03 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E039D43D39 for ; Tue, 15 Mar 2005 18:30:02 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j2FIU2iV072537 for ; Tue, 15 Mar 2005 18:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j2FIU2k8072536; Tue, 15 Mar 2005 18:30:02 GMT (envelope-from gnats) Resent-Date: Tue, 15 Mar 2005 18:30:02 GMT Resent-Message-Id: <200503151830.j2FIU2k8072536@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, LiangYi Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED9A216A4CE for ; Tue, 15 Mar 2005 18:22:31 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id D18B143D2D for ; Tue, 15 Mar 2005 18:22:31 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j2FIMUAt078633 for ; Tue, 15 Mar 2005 18:22:31 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id j2FIMUPs078632; Tue, 15 Mar 2005 18:22:30 GMT (envelope-from nobody) Message-Id: <200503151822.j2FIMUPs078632@www.freebsd.org> Date: Tue, 15 Mar 2005 18:22:30 GMT From: LiangYi To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: misc/78893: Fast forward will carsh the system in 5.x. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2005 18:30:03 -0000 >Number: 78893 >Category: misc >Synopsis: Fast forward will carsh the system in 5.x. >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 15 18:30:02 GMT 2005 >Closed-Date: >Last-Modified: >Originator: LiangYi >Release: 5.3 >Organization: lingzhou network Inc >Environment: FreeBSD 5.3-RELEASE >Description: It seems there is a bug in ip_fastfwd.c which will crash the system when it runs in fast forward mode occasionally. The crash enviroment will like this: net.inet.ip.fastforwarding = 1 Do a over MTU ping on a busy interface >How-To-Repeat: same as above. >Fix: Look at ip_fastfwd.c, function ip_fastforward, line 499. if_output will free the mbuf when it is failed. So if an error is occured 'm' will be freed, and the loop will break. Current code will free m twice which will crash the system later. Fix: update line 586 from: "for (; m; m = m0) {" to "for (; m = m0; ) {" >Release-Note: >Audit-Trail: >Unformatted: