From owner-svn-src-all@FreeBSD.ORG Mon Sep 19 16:10:30 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id E0B72106566B; Mon, 19 Sep 2011 16:10:30 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id A6F1A14DEC3; Mon, 19 Sep 2011 16:10:29 +0000 (UTC) Message-ID: <4E776973.9000409@FreeBSD.org> Date: Mon, 19 Sep 2011 09:10:27 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:6.0.2) Gecko/20110912 Thunderbird/6.0.2 MIME-Version: 1.0 To: Hiroki Sato References: <201109191555.p8JFtruR086396@svn.freebsd.org> In-Reply-To: <201109191555.p8JFtruR086396@svn.freebsd.org> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, re@FreeBSD.org, svn-src-all@freebsd.org, src-committers@freebsd.org, freebsd-rc@FreeBSD.org Subject: Re: svn commit: r225669 - head/etc/rc.d X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2011 16:10:31 -0000 Please don't add new instances of BEFORE in base rc.d scripts. The proper way to do this is to add bridge to REQUIRE: in SERVERS. The BEFORE method is useful for local/ports rc.d scripts, but it makes debugging of dependency issues more difficult so ideally it should be avoided in the base if it's not absolutely necessary (which it is not here). Thanks, Doug On 09/19/2011 08:55, Hiroki Sato wrote: > Author: hrs > Date: Mon Sep 19 15:55:53 2011 > New Revision: 225669 > URL: http://svn.freebsd.org/changeset/base/225669 > > Log: > Fix the script order to run rc.d/bridge after the initial network > interface configuration and before running network daemons. > > Approved by: re (kib) > > Modified: > head/etc/rc.d/bridge > > Modified: head/etc/rc.d/bridge > ============================================================================== > --- head/etc/rc.d/bridge Mon Sep 19 15:31:12 2011 (r225668) > +++ head/etc/rc.d/bridge Mon Sep 19 15:55:53 2011 (r225669) > @@ -26,7 +26,8 @@ > # > > # PROVIDE: bridge > -# REQUIRE: netif > +# REQUIRE: netif faith ppp stf > +# BEFORE: SERVERS > # KEYWORD: nojail > > . /etc/rc.subr > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/