From owner-svn-src-all@FreeBSD.ORG Mon May 17 19:40:04 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B6D281065670; Mon, 17 May 2010 19:40:04 +0000 (UTC) (envelope-from rpaulo@lavabit.com) Received: from karen.lavabit.com (karen.lavabit.com [72.249.41.33]) by mx1.freebsd.org (Postfix) with ESMTP id 5717C8FC08; Mon, 17 May 2010 19:40:04 +0000 (UTC) Received: from e.earth.lavabit.com (e.earth.lavabit.com [192.168.111.14]) by karen.lavabit.com (Postfix) with ESMTP id 1528B18F5BB; Mon, 17 May 2010 14:07:33 -0500 (CDT) Received: from 10.0.10.3 (54.81.54.77.rev.vodafone.pt [77.54.81.54]) by lavabit.com with ESMTP id PEPZU9FDEU3Q; Mon, 17 May 2010 14:07:33 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=qFGP764o8RtlELW7d4DT7v1wsqbM/A35mso2pHaQ/GFeubJYhHxRoowzMLBICldSMp6RS0LFeePm1VS7LyDPxXW5m1WfUxzcUbZinBk3+mvf29rp3hJs5GWEgZyXMndhhrwZ0oagtuRR40bG2O+eggq+zrSEdFHo0rlT//1YEc0=; h=Subject:Mime-Version:Content-Type:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: Date: Mon, 17 May 2010 20:07:29 +0100 Content-Transfer-Encoding: 7bit Message-Id: References: <201005161943.o4GJhnTo096839@svn.freebsd.org> To: Juli Mallett X-Mailer: Apple Mail (2.1078) Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r208165 - in head/sys: kern mips/conf mips/include mips/mips mips/rmi mips/rmi/dev/xlr X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2010 19:40:04 -0000 On 16 May 2010, at 20:54, Juli Mallett wrote: > On Sun, May 16, 2010 at 12:43, Randall Stewart wrote: >> Author: rrs >> Date: Sun May 16 19:43:48 2010 >> New Revision: 208165 >> URL: http://svn.freebsd.org/changeset/base/208165 >> >> Log: >> This pushes all of JC's patches that I have in place. I >> am now able to run 32 cores ok.. but I still will hang >> on buildworld with a NFS problem. I suspect I am missing >> a patch for the netlogic rge driver. >> >> JC check and see if I am missing anything except your >> core-mask changes > > This isn't a very good commit message. Commits communicate things > going forward. A follow-up E-Mail CCing JC would have been a good way > to chat with him about its completeness. More importantly, though, > there's just no description of the contents. This is particularly > frustrating as it's also not broken up into functional chunks very > well. Given the fact that there are MI changes and pan-MIPS changes > here it would be nice to see a little more care taken. The changes to > the MIPS MP code, for instance, I thought we had discussed and decided > were sub-par and easily made less invasive. I can't comment on the > RMI-specific stuff except to say that it's an unenumerated jumble of > VM, networking and SMP changes. I completely agree. Regards, -- Rui Paulo