From nobody Wed Jul 10 16:49:08 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WK3jJ2M9vz5Qmjf; Wed, 10 Jul 2024 16:49:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WK3jJ1dHPz4gQc; Wed, 10 Jul 2024 16:49:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720630148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Rf3cX9+V/ufxznSAnxQR6WZDxeFJGjQtESMEe76xVBU=; b=U/vASLRiTc/ZmwNTS7kTERScKSZ8dNxVsW0bawFGUcPy+oqf26Ss3n7QuncyqURZaDTZlQ fCRjB3N4GewkMUKdYr9wwbAXToFO0KJAvDC4I1ZN9/NxS1f0DucGsvCf7rcReYuHj7lrTm n7pHnbIDnfiOt0WQEIScvY4nlTzG6UF0F3Rn7KxHNi+mz7aYWZSTxA+lwMW35kBZKR8KwF V6592hw5PeXXBpvHpuUtFG1LS7XGgvUWPRL2DLClJOlhc4foaVvd9suk+ljG76B0nmHINB GTt0W/IkPtsTnUmWfl7OEUAtwag2bhqwl2iakXbqYnGgg08TSU5UmpDHnZo8Og== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1720630148; a=rsa-sha256; cv=none; b=UF6J1xa5BizakNhctXqGKFVbyWG0+Q05xGQLLt5W3EPz/Nq4PitD0nX5Yew9czGGRB/9p0 rs719/9/4drXF9nDuscFXnQ8U+AneHH1Tknq0ToLAA9/ZVL3D5wgV7JJwsq0ebTQkxnmY+ J+6Xba+oC+AjPChNT65hla6vRtj50YGdzbvzA9Ds2qMHpwRQusM7Zl8D2gjsHETTNoK14b 65p93tSOhfeKomxgpYsV71cdpuTNjp369c5teQZubxTdAIlLufB5bP269HRIWAHKhHw7uV RVo+qxI3k/k75Y9kAfKrufLnk7gZGPFybjHicA/OkiA43zdo94nOLoxg5K7fyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720630148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Rf3cX9+V/ufxznSAnxQR6WZDxeFJGjQtESMEe76xVBU=; b=xCVg3Y/d5V43rMxylB2/tiKJL753FwsDsaHU2pYCFuPm8LYUJim8zp1fOe/SITRUeuBfpR YqdlBV6K/M627Th5Xr7DLkWIN84wI/9i03ot5Eiq9/ZrKW6bk/GQFir18OQeUInq+ZcDYk eJNz0JJ1OvBGiJn++cZFnXebj886Azwq/v23JsbwbV8VeRCYMNOZxhLYnmEzneLgE0tIUL iUaK7thbATg1mMwl09VZirBtgG87CTwHEDJsJNdRPh8TzNKDoYtwktn+RTz+ANyLiIHxiv ondzR1wzN+D9sOKmKm3CT0KR9b70BteSisIJhBp+3tWnDcEkZpGH91ZAsCKE3g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WK3jJ18VfzQ5R; Wed, 10 Jul 2024 16:49:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46AGn84d035032; Wed, 10 Jul 2024 16:49:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46AGn8Fe035029; Wed, 10 Jul 2024 16:49:08 GMT (envelope-from git) Date: Wed, 10 Jul 2024 16:49:08 GMT Message-Id: <202407101649.46AGn8Fe035029@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: d325cd4a5302 - stable/14 - sound: Remove dead code in pcm_register() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d325cd4a530276cc05167e4a750fd53f32dbf86a Auto-Submitted: auto-generated The branch stable/14 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=d325cd4a530276cc05167e4a750fd53f32dbf86a commit d325cd4a530276cc05167e4a750fd53f32dbf86a Author: Christos Margiolis AuthorDate: 2024-07-06 18:22:55 +0000 Commit: Christos Margiolis CommitDate: 2024-07-10 16:48:13 +0000 sound: Remove dead code in pcm_register() Sponsored by: The FreeBSD Foundation MFC after: 2 days Differential Revision: https://reviews.freebsd.org/D45831 (cherry picked from commit a9f08df3e9004f431e98f67afc1ac2b2f773ec14) --- sys/dev/sound/pcm/sound.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/sys/dev/sound/pcm/sound.c b/sys/dev/sound/pcm/sound.c index 8d97dcd60231..b18b83468150 100644 --- a/sys/dev/sound/pcm/sound.c +++ b/sys/dev/sound/pcm/sound.c @@ -558,14 +558,7 @@ pcm_register(device_t dev, void *devinfo, int numplay, int numrec) d->lock = snd_mtxcreate(device_get_nameunit(dev), "sound cdev"); cv_init(&d->cv, device_get_nameunit(dev)); PCM_ACQUIRE_QUICK(d); -#if 0 - /* - * d->flags should be cleared by the allocator of the softc. - * We cannot clear this field here because several devices set - * this flag before calling pcm_register(). - */ - d->flags = 0; -#endif + i = 0; if (resource_int_value(device_get_name(dev), device_get_unit(dev), "vpc", &i) != 0 || i != 0)